Issue 7247018: Remove obsolete aggregating and non-working producers heap profilers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7247018: Remove obsolete aggregating and non-working producers heap profilers. (Closed)

Created:
9 years, 6 months ago by mnaganov (inactive)

Modified:
9 years, 6 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Remove obsolete aggregating and non-working producers heap profilers. 2000 LOC are gone! R=sgjesse@chromium.org BUG=1481 Committed: http://code.google.com/p/v8/source/detail?r=8406

Patch Set 1 #

Total comments: 2

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -2006 lines)			Patch
M	include/v8.h	View	1 chunk	+3 lines, -8 lines	0 comments	Download
M	include/v8-profiler.h	View	2 chunks	+2 lines, -11 lines	0 comments	Download
M	src/api.cc	View	4 chunks	+1 line, -32 lines	2 comments	Download
M	src/flag-definitions.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/heap.cc	View	4 chunks	+0 lines, -16 lines	0 comments	Download
M	src/heap-profiler.h	View	3 chunks	+0 lines, -295 lines	0 comments	Download
M	src/heap-profiler.cc	View	3 chunks	+0 lines, -988 lines	0 comments	Download
M	src/isolate.h	View	3 chunks	+0 lines, -11 lines	0 comments	Download
M	src/isolate.cc	View	3 chunks	+0 lines, -14 lines	0 comments	Download
M	src/log.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/log.cc	View	6 chunks	+0 lines, -97 lines	0 comments	Download
M	src/profile-generator.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	test/cctest/test-heap-profiler.cc	View	3 chunks	+0 lines, -496 lines	0 comments	Download
M	test/cctest/test-log.cc	View	1 chunk	+0 lines, -18 lines	0 comments	Download
M	tools/tickprocessor.js	View	2 chunks	+0 lines, -16 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

LGTM http://codereview.chromium.org/7247018/diff/1/src/api.cc File src/api.cc (right): http://codereview.chromium.org/7247018/diff/1/src/api.cc#newcode4857 src/api.cc:4857: i::Isolate* isolate = i::Isolate::Current(); Is it correct that ...

9 years, 6 months ago (2011-06-24 11:30:04 UTC) #2

mnaganov (inactive)

9 years, 6 months ago (2011-06-24 11:37:59 UTC) #3

http://codereview.chromium.org/7247018/diff/1/src/api.cc
File src/api.cc (right):

http://codereview.chromium.org/7247018/diff/1/src/api.cc#newcode4857
src/api.cc:4857: i::Isolate* isolate = i::Isolate::Current();
On 2011/06/24 11:30:05, Søren Gjesse wrote:
> Is it correct that there is no GC now?

Yes. GC was here to grap a heap snaphot (because the old snapshot was hooked
onto GC).

Expand Messages | Collapse Messages