Fix three GC unsafe places found by gcmole's dead_vars analysis.

Fix three GC unsafe places found by gcmole's dead_vars analysis.

Committed: http://code.google.com/p/v8/source/detail?r=8411

[Rico, 2011-06-23 19:32:02]

Human gcmole driveby :-)

http://codereview.chromium.org/7247013/diff/1/src/objects.cc
File src/objects.cc (right):

http://codereview.chromium.org/7247013/diff/1/src/objects.cc#newcode8445
src/objects.cc:8445: SetFastElementsCapacityAndLength(elms_length, length);
Shouldn't value be in an handle here, SetFastElementsCapacityAndLength can
(actually, always do) allocation. In addition, we return value several places
below where we could potentially have had allocation in between.

[Mads Ager (chromium), 2011-06-23 19:49:30]

LGTM!

http://codereview.chromium.org/7247013/diff/1/src/objects.cc
File src/objects.cc (right):

http://codereview.chromium.org/7247013/diff/1/src/objects.cc#newcode8445
src/objects.cc:8445: SetFastElementsCapacityAndLength(elms_length, length);
On 2011/06/23 19:32:02, Rico wrote:
> Shouldn't value be in an handle here, SetFastElementsCapacityAndLength can
> (actually, always do) allocation. In addition, we return value several places
> below where we could potentially have had allocation in between.

SetFastElementsCapacityAndLength does allocate, but it does not cause a GC. If
there is not enough room for the object it will return a failure. In that case
we will return in the line below and retry.