Issue 7247: Run GRIT on all platforms....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7247: Run GRIT on all platforms.... (Closed)

Created:
12 years, 2 months ago by Seo Sanghyeon

Modified:
9 years, 7 months ago

Reviewers:
tony, sgk

CC:
chromium-reviews_googlegroups.com

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Run GRIT on all platforms. * RCFLAGS may not exist in SCons environment. Use empty list if absent. * Accumulate generated files in grit_files and run RES on win32 only.

Patch Set 1 #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -27 lines)			Patch
	M	chrome/SConscript	View		2 chunks	+28 lines, -26 lines	0 comments	Download
	M	tools/grit/grit/scons.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

tony

FWIW, I think this is ok to do. The generated .rc and .h files aren't ...

12 years, 2 months ago (2008-10-10 23:37:25 UTC) #2

sgk

lgtm On non-Windows platforms, the .rc files shouldn't even get built unless something else in ...

12 years, 2 months ago (2008-10-11 00:07:02 UTC) #3

tony

12 years, 2 months ago (2008-10-17 06:17:45 UTC) #4

Committed in r3517 from <http://codereview.chromium.org/7614>.  I'm going to
close this issue now.

Expand Messages | Collapse Messages