Change timeType and dateType in i18n date format API into timeStyle and dateStyle to match the pr...

Change timeType and dateType in i18n date format API into timeStyle and dateStyle to match the proposal.
I've kept old keys too, until ChromeOS user switches to time/dateStyle.

Fixed regex for matching styles in date and number format.

TEST=i18n.kaziprst.org/datetimeformat.html should show proper results for both timeType and timeStyle.
Committed: http://code.google.com/p/v8/source/detail?r=8423

[rginda, 2011-06-23 18:24:15]

Thanks for keep the old keys around for a little while.  I imagine I'll just use
both dateStyle and dateType until things settle down.

http://codereview.chromium.org/7244008/diff/1/src/extensions/experimental/i18...
File src/extensions/experimental/i18n.js (right):

http://codereview.chromium.org/7244008/diff/1/src/extensions/experimental/i18...
src/extensions/experimental/i18n.js:165: if
(!/^short|medium|long|full$/.test(dt)) ds = 'short';
You'll need to parenthesize that regexp...
  /^(short|medium|long|full)$/

http://codereview.chromium.org/7244008/diff/1/src/extensions/experimental/i18...
src/extensions/experimental/i18n.js:178: if
(!/^short|medium|long|full$/.test(tt)) ts = 'short';
Here too.

[Nebojša Ćirić, 2011-06-23 18:48:45]

Fixed regex in number format section to have ^()$.

http://codereview.chromium.org/7244008/diff/1/src/extensions/experimental/i18...
File src/extensions/experimental/i18n.js (right):

http://codereview.chromium.org/7244008/diff/1/src/extensions/experimental/i18...
src/extensions/experimental/i18n.js:165: if
(!/^short|medium|long|full$/.test(dt)) ds = 'short';
On 2011/06/23 18:24:16, rginda wrote:
> You'll need to parenthesize that regexp...
>   /^(short|medium|long|full)$/

Done.

http://codereview.chromium.org/7244008/diff/1/src/extensions/experimental/i18...
src/extensions/experimental/i18n.js:178: if
(!/^short|medium|long|full$/.test(tt)) ts = 'short';
On 2011/06/23 18:24:16, rginda wrote:
> Here too.

Done.

[jungshik at Google, 2011-06-24 16:33:47]

LGTM

http://codereview.chromium.org/7244008/diff/4002/src/extensions/experimental/...
File src/extensions/experimental/i18n.js (right):

http://codereview.chromium.org/7244008/diff/4002/src/extensions/experimental/...
src/extensions/experimental/i18n.js:184: cleanSettings['timeStyle'] = tt;
given that this will go away later, I wouldn't say you have to refactor what's
inside if-block and else-if-block :-) If you like, you can.

[Nebojša Ćirić, 2011-06-24 16:43:22]

Thanks

http://codereview.chromium.org/7244008/diff/4002/src/extensions/experimental/...
File src/extensions/experimental/i18n.js (right):

http://codereview.chromium.org/7244008/diff/4002/src/extensions/experimental/...
src/extensions/experimental/i18n.js:184: cleanSettings['timeStyle'] = tt;
I am not going to refactor - current code makes it easy to delete else if part
in the future without too much thinking :).

On 2011/06/24 16:33:47, Jungshik Shin wrote:
> given that this will go away later, I wouldn't say you have to refactor what's
> inside if-block and else-if-block :-) If you like, you can. 
>