Change many extension event routers to not be singletons and to be more profile-aware.

chrome/browser/chromeos/extensions/file_browser_event_router.cc

Index: chrome/browser/chromeos/extensions/file_browser_event_router.cc
diff --git a/chrome/browser/chromeos/extensions/file_browser_event_router.cc b/chrome/browser/chromeos/extensions/file_browser_event_router.cc
index d4fb18406e33c8117b482be5f6e2735f984c8615..149dd507a4aa4fec46429630c27ce651bd01ec19 100644
--- a/chrome/browser/chromeos/extensions/file_browser_event_router.cc
+++ b/chrome/browser/chromeos/extensions/file_browser_event_router.cc
@@ -55,9 +55,10 @@ DictionaryValue* DiskToDictionaryValue(
   return result;
 }
 
-ExtensionFileBrowserEventRouter::ExtensionFileBrowserEventRouter()
+ExtensionFileBrowserEventRouter::ExtensionFileBrowserEventRouter(
+    Profile* profile)
     : delegate_(new ExtensionFileBrowserEventRouter::FileWatcherDelegate()),
-      profile_(NULL) {
+      profile_(profile) {
 }
 
 ExtensionFileBrowserEventRouter::~ExtensionFileBrowserEventRouter() {
@@ -71,20 +72,11 @@ ExtensionFileBrowserEventRouter::~ExtensionFileBrowserEventRouter() {
   chromeos::MountLibrary* lib =
       chromeos::CrosLibrary::Get()->GetMountLibrary();
   lib->RemoveObserver(this);
-  profile_ = NULL;
 }
 
-// static
-ExtensionFileBrowserEventRouter*
-  ExtensionFileBrowserEventRouter::GetInstance() {
-  return Singleton<ExtensionFileBrowserEventRouter>::get();
-}
-
-void ExtensionFileBrowserEventRouter::ObserveFileSystemEvents(
-    Profile* profile) {
-  if (!profile)
+void ExtensionFileBrowserEventRouter::Init() {
+  if (!profile_)

[asargent_no_longer_on_chrome, 2011/06/23 22:18:38]

Should we have NOTREACHED() or CHECK(false) here instead of ignoring it? 

[Yoyo Zhou, 2011/06/24 17:21:38]

Sure.

     return;
-  profile_ = profile;
   if (!chromeos::CrosLibrary::Get()->EnsureLoaded())
     return;
   if (chromeos::UserManager::Get()->user_is_logged_in()) {
@@ -133,17 +125,6 @@ void ExtensionFileBrowserEventRouter::RemoveFileWatch(
   }
 }
 
-void ExtensionFileBrowserEventRouter::StopObservingFileSystemEvents() {
-  if (!profile_)
-    return;
-  if (!chromeos::CrosLibrary::Get()->EnsureLoaded())
-    return;
-  chromeos::MountLibrary* lib =
-      chromeos::CrosLibrary::Get()->GetMountLibrary();
-  lib->RemoveObserver(this);
-  profile_ = NULL;
-}
-
 void ExtensionFileBrowserEventRouter::DiskChanged(
     chromeos::MountLibraryEventType event,
     const chromeos::MountLibrary::Disk* disk) {