Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6696)

Unified Diff: chrome/browser/ui/panels/panel_browser_view_browsertest.cc

Issue 7242017: Support minimizing the panel into 3-pixel line on Windows. Also support bringing up/down the titl... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/panels/panel_browser_view_browsertest.cc
===================================================================
--- chrome/browser/ui/panels/panel_browser_view_browsertest.cc (revision 90982)
+++ chrome/browser/ui/panels/panel_browser_view_browsertest.cc (working copy)
@@ -277,6 +277,44 @@
browser_view1->panel()->Close();
browser_view2->panel()->Close();
}
+
+ // We put all the testing logic in this class instead of the test so that
+ // we do not need to declare each new test as a friend of PanelBrowserView
+ // for the purpose of accessing its private members.
+ void TestMinimizeAndRestore() {
+ PanelBrowserView* browser_view = CreatePanelBrowserView("PanelTest",
+ SHOW_AS_ACTIVE);
+ Panel* panel = browser_view->panel_.get();
+
+ EXPECT_EQ(Panel::EXPANDED, panel->expansion_state());
+ int initial_height = panel->GetBounds().height();
+ int titlebar_height =
+ browser_view->GetFrameView()->NonClientTopBorderHeight();
+
+ browser_view->SetPanelExpansionState(Panel::MINIMIZED);
jennb 2011/06/29 23:17:54 Should this be panel->SetPanelExpansionState()?
jianli 2011/06/30 01:28:33 Done.
+ EXPECT_EQ(Panel::MINIMIZED, panel->expansion_state());
+ EXPECT_LT(panel->GetBounds().height(), titlebar_height);
+ EXPECT_GT(panel->GetBounds().height(), 0);
+
+ browser_view->SetPanelExpansionState(Panel::TITLE_ONLY);
+ EXPECT_EQ(Panel::TITLE_ONLY, panel->expansion_state());
+ EXPECT_EQ(titlebar_height, panel->GetBounds().height());
+
+ browser_view->SetPanelExpansionState(Panel::EXPANDED);
+ EXPECT_EQ(Panel::EXPANDED, panel->expansion_state());
+ EXPECT_EQ(initial_height, panel->GetBounds().height());
+
+ browser_view->SetPanelExpansionState(Panel::TITLE_ONLY);
+ EXPECT_EQ(Panel::TITLE_ONLY, panel->expansion_state());
+ EXPECT_EQ(initial_height, panel->GetBounds().height());
+
+ browser_view->SetPanelExpansionState(Panel::MINIMIZED);
+ EXPECT_EQ(Panel::MINIMIZED, panel->expansion_state());
+ EXPECT_LT(panel->GetBounds().height(), titlebar_height);
+ EXPECT_GT(panel->GetBounds().height(), 0);
+
+ browser_view->panel()->Close();
+ }
};
// Panel is not supported for Linux view yet.
@@ -587,4 +625,8 @@
FILE_PATH_LITERAL("extension2"), Extension::INVALID,
"http://home", "options.html");
}
+
+IN_PROC_BROWSER_TEST_F(PanelBrowserViewTest, MinimizeAndRestore) {
+ TestMinimizeAndRestore();
+}
#endif

Powered by Google App Engine
This is Rietveld 408576698