Chromium Code Reviews| Index: chrome/browser/ui/panels/panel_browser_view_browsertest.cc |
| =================================================================== |
| --- chrome/browser/ui/panels/panel_browser_view_browsertest.cc (revision 90982) |
| +++ chrome/browser/ui/panels/panel_browser_view_browsertest.cc (working copy) |
| @@ -277,6 +277,44 @@ |
| browser_view1->panel()->Close(); |
| browser_view2->panel()->Close(); |
| } |
| + |
| + // We put all the testing logic in this class instead of the test so that |
| + // we do not need to declare each new test as a friend of PanelBrowserView |
| + // for the purpose of accessing its private members. |
| + void TestMinimizeAndRestore() { |
| + PanelBrowserView* browser_view = CreatePanelBrowserView("PanelTest", |
| + SHOW_AS_ACTIVE); |
| + Panel* panel = browser_view->panel_.get(); |
| + |
| + EXPECT_EQ(Panel::EXPANDED, panel->expansion_state()); |
| + int initial_height = panel->GetBounds().height(); |
| + int titlebar_height = |
| + browser_view->GetFrameView()->NonClientTopBorderHeight(); |
| + |
| + browser_view->SetPanelExpansionState(Panel::MINIMIZED); |
|
jennb
2011/06/29 23:17:54
Should this be panel->SetPanelExpansionState()?
jianli
2011/06/30 01:28:33
Done.
|
| + EXPECT_EQ(Panel::MINIMIZED, panel->expansion_state()); |
| + EXPECT_LT(panel->GetBounds().height(), titlebar_height); |
| + EXPECT_GT(panel->GetBounds().height(), 0); |
| + |
| + browser_view->SetPanelExpansionState(Panel::TITLE_ONLY); |
| + EXPECT_EQ(Panel::TITLE_ONLY, panel->expansion_state()); |
| + EXPECT_EQ(titlebar_height, panel->GetBounds().height()); |
| + |
| + browser_view->SetPanelExpansionState(Panel::EXPANDED); |
| + EXPECT_EQ(Panel::EXPANDED, panel->expansion_state()); |
| + EXPECT_EQ(initial_height, panel->GetBounds().height()); |
| + |
| + browser_view->SetPanelExpansionState(Panel::TITLE_ONLY); |
| + EXPECT_EQ(Panel::TITLE_ONLY, panel->expansion_state()); |
| + EXPECT_EQ(initial_height, panel->GetBounds().height()); |
| + |
| + browser_view->SetPanelExpansionState(Panel::MINIMIZED); |
| + EXPECT_EQ(Panel::MINIMIZED, panel->expansion_state()); |
| + EXPECT_LT(panel->GetBounds().height(), titlebar_height); |
| + EXPECT_GT(panel->GetBounds().height(), 0); |
| + |
| + browser_view->panel()->Close(); |
| + } |
| }; |
| // Panel is not supported for Linux view yet. |
| @@ -587,4 +625,8 @@ |
| FILE_PATH_LITERAL("extension2"), Extension::INVALID, |
| "http://home", "options.html"); |
| } |
| + |
| +IN_PROC_BROWSER_TEST_F(PanelBrowserViewTest, MinimizeAndRestore) { |
| + TestMinimizeAndRestore(); |
| +} |
| #endif |