Support minimizing the panel into 3-pixel line on Windows. Also support bringing up/down the titl...

chrome/browser/ui/panels/native_panel.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_PANELS_NATIVE_PANEL_H_
 #define CHROME_BROWSER_UI_PANELS_NATIVE_PANEL_H_
 #pragma once
 
+#include "chrome/browser/ui/panels/panel.h"

[jennb, 2011/06/29 23:17:54]

Gut reaction was this include felt circular. We're only including it for the
ExpansionState enum, right? Maybe that should go in some panel_constants.h
file...

[jianli, 2011/06/30 01:28:33]

It is really not circular. Though it is kind of ugly, we do not want to move it
to a new header file that has it exposed directly. I keep it as now per our
discussion.

 #include "ui/gfx/native_widget_types.h"
 
 class Panel;
 
 namespace gfx {
 class Rect;
 }  // namespace gfx
 
 // An interface for a class that implements platform-specific behavior for panel
 // windows. We use this interface for two reasons:
 // 1. We don't want to use BrowserWindow as the interface between shared panel
 //    code and platform-specific code. BrowserWindow has a lot of methods, most
 //    of which we don't use and simply stub out with NOTIMPLEMENTED().
 // 2. We need some additional methods that BrowserWindow doesn't provide, such
 //    as MinimizePanel() and RestorePanel().
 // Note that even though we don't use BrowserWindow directly, Windows and GTK+
 // still use the BrowserWindow interface as part of their implementation so we
 // use Panel in all the method names to avoid collisions.
 class NativePanel {
   friend class Panel;
 
  protected:
   virtual ~NativePanel() {}
 
   virtual void ShowPanel() = 0;
   virtual void ShowPanelInactive() = 0;
   virtual gfx::Rect GetPanelBounds() const = 0;
   virtual void SetPanelBounds(const gfx::Rect& bounds) = 0;
-  virtual void MinimizePanel() = 0;
-  virtual void RestorePanel() = 0;
+  virtual void SetPanelExpansionState(
+      Panel::ExpansionState expansion_state) = 0;
+  virtual bool ShouldBringUpPanelTitleBar(int mouse_x, int mouse_y) const = 0;

[jennb, 2011/06/29 23:17:54]

Could you add comments explaining what x and y are and describe the purpose of
this method?

[jianli, 2011/06/30 01:28:33]

Done.

   virtual void ClosePanel() = 0;
   virtual void ActivatePanel() = 0;
   virtual void DeactivatePanel() = 0;
   virtual bool IsPanelActive() const = 0;
   virtual gfx::NativeWindow GetNativePanelHandle() = 0;
   virtual void UpdatePanelTitleBar() = 0;
   virtual void ShowTaskManagerForPanel() = 0;
   virtual void NotifyPanelOnUserChangedTheme() = 0;
   virtual void FlashPanelFrame() = 0;
   virtual void DestroyPanelBrowser() = 0;
 };
 
 #endif  // CHROME_BROWSER_UI_PANELS_NATIVE_PANEL_H_