Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 7241024: Mostly minor changes such as adding <code></code> around elements, a little rewriting, and a few ... (Closed)

Created:
9 years, 6 months ago by jond
Modified:
9 years, 5 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Visibility:
Public.

Description

Mostly minor changes such as adding <code></code> around elements, a little rewriting, and a few new documentation bits to pp_var.h. Mostly trying to ensure consistency across all docs and doing cleanup. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91221

Patch Set 1 #

Total comments: 27

Patch Set 2 : '' #

Total comments: 5

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -112 lines) Patch
M ppapi/c/pp_bool.h View 1 2 3 chunks +5 lines, -4 lines 0 comments Download
M ppapi/c/pp_completion_callback.h View 1 2 5 chunks +41 lines, -24 lines 0 comments Download
M ppapi/c/pp_errors.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ppapi/c/pp_input_event.h View 1 2 8 chunks +24 lines, -14 lines 0 comments Download
M ppapi/c/pp_point.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M ppapi/c/pp_rect.h View 1 2 3 chunks +8 lines, -5 lines 0 comments Download
M ppapi/c/pp_resource.h View 1 2 2 chunks +6 lines, -5 lines 0 comments Download
M ppapi/c/pp_size.h View 1 2 3 chunks +7 lines, -4 lines 0 comments Download
M ppapi/c/pp_time.h View 1 2 3 chunks +9 lines, -9 lines 0 comments Download
M ppapi/c/pp_var.h View 1 2 10 chunks +79 lines, -42 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jond
9 years, 6 months ago (2011-06-24 16:17:19 UTC) #1
dmichael (off chromium)
http://codereview.chromium.org/7241024/diff/1/ppapi/c/pp_completion_callback.h File ppapi/c/pp_completion_callback.h (right): http://codereview.chromium.org/7241024/diff/1/ppapi/c/pp_completion_callback.h#newcode31 ppapi/c/pp_completion_callback.h:31: * information such as bytes read. I know this ...
9 years, 6 months ago (2011-06-27 15:45:41 UTC) #2
jond
http://codereview.chromium.org/7241024/diff/1/ppapi/c/pp_completion_callback.h File ppapi/c/pp_completion_callback.h (right): http://codereview.chromium.org/7241024/diff/1/ppapi/c/pp_completion_callback.h#newcode31 ppapi/c/pp_completion_callback.h:31: * information such as bytes read. Polinia mentioned that ...
9 years, 5 months ago (2011-06-29 21:14:37 UTC) #3
dmichael (off chromium)
http://codereview.chromium.org/7241024/diff/10001/ppapi/c/pp_completion_callback.h File ppapi/c/pp_completion_callback.h (right): http://codereview.chromium.org/7241024/diff/10001/ppapi/c/pp_completion_callback.h#newcode29 ppapi/c/pp_completion_callback.h:29: * values, other than -1, indicate error and are ...
9 years, 5 months ago (2011-06-30 10:03:48 UTC) #4
jond
http://codereview.chromium.org/7241024/diff/10001/ppapi/c/pp_completion_callback.h File ppapi/c/pp_completion_callback.h (right): http://codereview.chromium.org/7241024/diff/10001/ppapi/c/pp_completion_callback.h#newcode29 ppapi/c/pp_completion_callback.h:29: * values, other than -1, indicate error and are ...
9 years, 5 months ago (2011-06-30 16:24:16 UTC) #5
dmichael (off chromium)
9 years, 5 months ago (2011-06-30 17:35:12 UTC) #6
LGTM, thanks!

Powered by Google App Engine
This is Rietveld 408576698