Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 7241003: Fix a bug where window.screen would return 0, 0 as the width and height (Closed)

Created:
9 years, 6 months ago by tony
Modified:
9 years, 6 months ago
Reviewers:
jam, Daniel Erat
CC:
chromium-reviews, joi+watch-content_chromium.org, jam
Visibility:
Public.

Description

Fix a bug where window.screen would return 0, 0 as the width and height if the page requesting the dimensions didn't have a GDK window associated with it and there was no GDK window under the mouse pointer. Instead of using gdk_display_get_window_at_pointer, use gdk_display_get_default_group which will always return a valid value. This means extension background pages will always get the screen size of the primary monitor. BUG=86605 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90231

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/browser/renderer_host/render_widget_host_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
tony
9 years, 6 months ago (2011-06-22 21:46:04 UTC) #1
Daniel Erat
LGTM
9 years, 6 months ago (2011-06-22 22:40:41 UTC) #2
tony
+jam for content approval
9 years, 6 months ago (2011-06-22 22:44:25 UTC) #3
jam
9 years, 6 months ago (2011-06-23 18:05:01 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698