net/base/net_api.h - Issue 7240021: net: Add NET_API for some linux-only files

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/base/net_api.h

Issue 7240021: net: Add NET_API for some linux-only files (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef NET_BASE_NET_API_H_	5 #ifndef NET_BASE_NET_API_H_

6 #define NET_BASE_NET_API_H_	6 #define NET_BASE_NET_API_H_

7 #pragma once	7 #pragma once

8	8

9 // Defines NET_API so that funtionality implemented by the net module can be	9 // Defines NET_API so that funtionality implemented by the net module can be

10 // exported to consumers, and NET_TEST that allows unit tests to access features	10 // exported to consumers, and NET_TEST that allows unit tests to access features

11 // not intended to be used directly by real consumers.	11 // not intended to be used directly by real consumers.

12	12

13 #if defined(WIN32) && defined(NET_DLL)	13 #if defined(NET_DLL)

	14 #if defined(WIN32)

14 #if defined(NET_IMPLEMENTATION)	15 #if defined(NET_IMPLEMENTATION)

15 #define NET_API __declspec(dllexport)	16 #define NET_API __declspec(dllexport)

16 #define NET_TEST __declspec(dllexport)	17 #define NET_TEST __declspec(dllexport)

17 #else	18 #else

18 #define NET_API __declspec(dllimport)	19 #define NET_API __declspec(dllimport)

19 #define NET_TEST __declspec(dllimport)	20 #define NET_TEST __declspec(dllimport)

20 #endif // defined(NET_IMPLEMENTATION)	21 #endif // defined(NET_IMPLEMENTATION)

21 #else	22 #else

	23 #define NET_API __attribute__((visibility("default")))

	24 #define NET_TEST __attribute__((visibility("default")))
	wtc 2011/06/24 16:38:51 I guess there is a corresponding GYP file change t I guess there is a corresponding GYP file change to compile with -fvisibility=hidden?
	25 #endif // defined(WIN32)

	26 #else

22 #define NET_API	27 #define NET_API

23 #define NET_TEST	28 #define NET_TEST

24 #endif	29 #endif
	wtc 2011/06/24 16:36:26 I suggest adding some blank lines to make the stru I suggest adding some blank lines to make the structure of this nested ifdef clearer.
25	30

26 #endif // NET_BASE_NET_API_H_	31 #endif // NET_BASE_NET_API_H_

OLD	NEW

« no previous file with comments | « no previous file | net/http/http_auth_gssapi_posix.h » ('j') | net/socket/client_socket_pool_manager.h » ('J')