Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7212)

Unified Diff: chrome/chrome_exe.gypi

Issue 7240019: Now try and make -pie stick for 32-bit Linux too. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_exe.gypi
===================================================================
--- chrome/chrome_exe.gypi (revision 89999)
+++ chrome/chrome_exe.gypi (working copy)
@@ -201,11 +201,10 @@
['disable_pie==1', {
'ldflags': ['-nopie'],
}, {
- # Building with -fPIE fails on ARM and ia32 bots.
- # http://code.google.com/p/chromium/issues/detail?id=57908
- # Until that is fixed, at least use it on Linux 64-bit.
+ # Building with -pie needs investigating on ARM.
+ # For now, at least use it on Linux Intel.
'conditions': [
- ['target_arch=="x64"', {
+ ['target_arch=="x64" or target_arch=="ia32"', {
'ldflags': ['-pie'],
}],
],
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698