add trackpad driver in st1.5

add trackpad driver in st1.5

BUG=NONE
TEST=Built and ran on st1.5
Signed-off-by: Horace Fu <horace.fu@quantatw.com>;

[nleeder, 2010-03-09 21:18:44]

Please review all of the comments I made on this file in the first patch
http://codereview.chromium.org/669053/show , as well as Bryan's more general
comments.  This driver file appears to be the same, so all previous comments
still apply.

[Horace, 2010-03-11 12:49:41]

On 2010/03/09 21:18:44, nleeder wrote:

Please help to review once again, thanks!

[nleeder, 2010-03-11 23:05:24]

Horace, please make sure you're a member of the chromium-os-reviews mailing
list: 
http://groups.google.com/a/chromium.org/group/chromium-os-reviews/topics click
"join this group". This way all comments you make on reviews will also show up
on the mailing list.

Please add a Signed-off-by line at the end of the patch commit text:
Signed-off-by: Horace Fu <horace.fu@quantatw.com>

The changes you made to the qci-touchpad.c file look good - thanks!

http://codereview.chromium.org/724001/diff/3001/4001
File arch/arm/mach-msm/board-qsd8x50.c (right):

http://codereview.chromium.org/724001/diff/3001/4001#newcode1974
arch/arm/mach-msm/board-qsd8x50.c:1974: .irq = TOUCHPAD_INT_GPIO
These changes in the board-qsd8x50.c file are correct, but they shouldn't be
included in this patch. Changes in the driver tree and msm tree should be in
separate patches. Please remove board-qsd8x50.c from this patch. Qualcomm can
add the msm patch.

http://codereview.chromium.org/724001/diff/3001/4002
File drivers/input/mouse/Kconfig (right):

http://codereview.chromium.org/724001/diff/3001/4002#newcode326
drivers/input/mouse/Kconfig:326: default m
Should have a depends line such as:
depends on I2C && ARCH_MSM_SCORPION

Also it should default to 'n'. In the defconfig file for the appropriate target
system it can be selected as 'm'. Qualcomm can do that patch.

[Horace, 2010-03-12 05:54:37]

On 2010/03/11 23:05:24, nleeder wrote:

really appreciate your help, and have done some modifications.

[nleeder, 2010-03-12 18:16:19]

LGTM

[nleeder, 2010-03-16 20:20:02]

+msb, mbligh, tgardner

Could I get an additional reviewer for this patch please? It's for the ARM-based
Qualcomm ST1.5 platform. Thanks.

[Mandeep Singh Baines, 2010-03-17 17:37:43]

Please run scripts/checkpatch.pl on qci_touchpad.c and fix all errors.

http://codereview.chromium.org/724001/diff/12002/14001
File drivers/input/mouse/Kconfig (right):

http://codereview.chromium.org/724001/diff/12002/14001#newcode330
drivers/input/mouse/Kconfig:330: 
80 char

http://codereview.chromium.org/724001/diff/12002/14002
File drivers/input/mouse/Makefile (right):

http://codereview.chromium.org/724001/diff/12002/14002#newcode33
drivers/input/mouse/Makefile:33: obj-$(CONFIG_MOUSE_QCITP)		+= qci_touchpad.o
To be consistent, maybe this should go on line 23?

[Mandeep Singh Baines, 2010-03-17 18:28:31]

Some minor nits.

http://codereview.chromium.org/724001/diff/12002/14003
File drivers/input/mouse/qci_touchpad.c (right):

http://codereview.chromium.org/724001/diff/12002/14003#newcode63
drivers/input/mouse/qci_touchpad.c:63: return snprintf(msg, 64, "Sensitivity is
%d.\n", tp_sense_val);
snprintf(buffer, PAGE_SIZE, "%d\n", tp_sense_val);

http://codereview.chromium.org/724001/diff/12002/14003#newcode75
drivers/input/mouse/qci_touchpad.c:75: snprintf(msg, 64, "The Valid range is
1~10 \n");
This is never used.

http://codereview.chromium.org/724001/diff/12002/14003#newcode82
drivers/input/mouse/qci_touchpad.c:82: static struct kobj_attribute
tp_sensitivity = {
Use __ATTR macro from sysfs.h.

http://codereview.chromium.org/724001/diff/12002/14003#newcode91
drivers/input/mouse/qci_touchpad.c:91: static struct attribute *g_tp[] = {
Maybe this should be a struct device_attribute?

http://codereview.chromium.org/724001/diff/12002/14003#newcode93
drivers/input/mouse/qci_touchpad.c:93: NULL,
__ATTR_NULL

[Mandeep Singh Baines, 2010-03-18 22:07:36]

Please add sign-off-by to this patch.

http://codereview.chromium.org/724001/diff/12002/14003
File drivers/input/mouse/qci_touchpad.c (right):

http://codereview.chromium.org/724001/diff/12002/14003#newcode129
drivers/input/mouse/qci_touchpad.c:129: .name  = TOUCHPAD_ID_NAME,
.pm =

http://codereview.chromium.org/724001/diff/12002/14003#newcode134
drivers/input/mouse/qci_touchpad.c:134: .resume   = qcitp_resume,
Use .pm instead.

[Horace, 2010-03-23 11:45:03]

follow suggestions to correct some format.

[Mandeep Singh Baines, 2010-03-23 18:06:03]

Code looks fantastic! Thanks much!

Just missing the Signed-off-by in the commit log.
Please click "Edit issue" on the codereview site for this change and add the
Signed-off-by. We'll then be able to commit this code.

Also, one minor spelling mistake you might want to fix.

http://codereview.chromium.org/724001/diff/26001/27003
File drivers/input/mouse/qci_touchpad.c (right):

http://codereview.chromium.org/724001/diff/26001/27003#newcode234
drivers/input/mouse/qci_touchpad.c:234: /*request intterrupt*/
request interrupt

[Horace, 2010-03-24 02:02:18]

On 2010/03/23 18:06:03, msb wrote:

I had already add a line with signed-off-by last night.
Do I need to add the other reviewers about this part?
If the answer is yes, where can get full name such as below description?
http://codereview.chromium.org/646032

[Mandeep Singh Baines, 2010-03-25 04:11:24]

Thanks! Committed to qualcomm-2.6.31.12

http://src.chromium.org/cgi-bin/gitweb.cgi?p=kernel.git;a=commit;h=c2b6814b9c...