Issue 7240005: Prevent settings page from closing when someone clicks an <option> in a <select>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7240005: Prevent settings page from closing when someone clicks an <option> in a <select>. (Closed)

Created:
9 years, 6 months ago by koz (OOO until 15th September)

Modified:
9 years, 5 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

Description

Prevent settings pages from closing when someone clicks an <option> in a <select>. BUG=87199 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90167

Patch Set 1 #

Total comments: 1

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	chrome/browser/resources/options/options_page.js	View		1 chunk	+6 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

9 years, 6 months ago (2011-06-23 02:05:04 UTC) #2

lgtm

http://codereview.chromium.org/7240005/diff/1/chrome/browser/resources/option...
File chrome/browser/resources/options/options_page.js (right):

http://codereview.chromium.org/7240005/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options/options_page.js:704: // coordinates when a user
selects a new entry in a select element.
add crbug link

Expand Messages | Collapse Messages