Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(823)

Issue 7239023: Move the thread test helper to base/test (Closed)

Created:
9 years, 6 months ago by jochen (gone - plz use gerrit)
Modified:
9 years, 5 months ago
CC:
chromium-reviews, michaeln, cbentzel+watch_chromium.org, nkostylev+cc_chromium.org, Erik does not do reviews, brettw-cc_chromium.org, jam, Randy Smith (Not in Mondays), joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, Paweł Hajdan Jr., davemoore+watch_chromium.org
Visibility:
Public.

Description

Move the thread test helper to base/test BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90723

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -122 lines) Patch
M base/base.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
A + base/test/thread_test_helper.h View 3 chunks +16 lines, -13 lines 0 comments Download
A + base/test/thread_test_helper.cc View 2 chunks +8 lines, -4 lines 0 comments Download
M chrome/browser/browsing_data_local_storage_helper_browsertest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/parallel_authenticator_unittest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/signed_settings_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_event_router_forwarder_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/net/sqlite_persistent_cookie_store_unittest.cc View 6 chunks +16 lines, -11 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/test/thread_test_helper.h View 1 chunk +0 lines, -46 lines 0 comments Download
D chrome/test/thread_test_helper.cc View 1 chunk +0 lines, -29 lines 0 comments Download
M content/browser/appcache/chrome_appcache_service_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/in_process_webkit/dom_storage_browsertest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M content/browser/in_process_webkit/indexed_db_browsertest.cc View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
please review I want to use this helper from webkit/database, so it needs to be ...
9 years, 6 months ago (2011-06-24 11:47:17 UTC) #1
darin (slow to review)
LGTM
9 years, 6 months ago (2011-06-24 16:49:27 UTC) #2
commit-bot: I haz the power
9 years, 6 months ago (2011-06-24 17:15:14 UTC) #3
Can't process patch for file base/test/thread_test_helper.h.
A +

Powered by Google App Engine
This is Rietveld 408576698