base/logging.h - Issue 7238012: Upstream android debug and log related files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/logging.h

Issue 7238012: Upstream android debug and log related files (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove the android guard around ctype.h Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/logging.h

diff --git a/base/logging.h b/base/logging.h

index b12defcfe6d941cd94a8c5a1df387e8eba3a67d5..849de0e33292ffdb1b217b94c5fece07bd38ab5f 100644

--- a/base/logging.h

+++ b/base/logging.h

@@ -703,7 +703,12 @@ const LogSeverity LOG_DCHECK = LOG_INFO;

#define DCHECK_GE(val1, val2) DCHECK_OP(GE, >=, val1, val2)

#define DCHECK_GT(val1, val2) DCHECK_OP(GT, > , val1, val2)

+#if defined(OS_ANDROID) && !defined(OFFICIAL_BUILD)

+// TODO(port): fix once "enough" works

+#define NOTREACHED() LOG(ERROR) << "NOTREACHED()"

+#else

#define NOTREACHED() DCHECK(false)

+#endif

// Redefine the standard assert to use our nice log files

#undef assert

« no previous file with comments | « base/debug/stack_trace_android.cc ('k') | base/logging.cc » ('j') | no next file with comments »