Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7862)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/logging.h

Issue 7238012: Upstream android debug and log related files (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/debug/debugger_posix.cc ('K') | « base/debug/stack_trace_android.cc ('k') | base/logging.cc » ('j') | base/port.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/logging.h
diff --git a/base/logging.h b/base/logging.h
index b12defcfe6d941cd94a8c5a1df387e8eba3a67d5..849de0e33292ffdb1b217b94c5fece07bd38ab5f 100644
--- a/base/logging.h
+++ b/base/logging.h
@@ -703,7 +703,12 @@ const LogSeverity LOG_DCHECK = LOG_INFO;
#define DCHECK_GE(val1, val2) DCHECK_OP(GE, >=, val1, val2)
#define DCHECK_GT(val1, val2) DCHECK_OP(GT, > , val1, val2)
+#if defined(OS_ANDROID) && !defined(OFFICIAL_BUILD)
+// TODO(port): fix once "enough" works
brettw 2011/06/24 22:23:57 Do you think "enough" works now? I can imagine thi
michaelbai 2011/06/24 23:30:44 We haven't ready yet :(
+#define NOTREACHED() LOG(ERROR) << "NOTREACHED()"
+#else
#define NOTREACHED() DCHECK(false)
+#endif
// Redefine the standard assert to use our nice log files
#undef assert
« base/debug/debugger_posix.cc ('K') | « base/debug/stack_trace_android.cc ('k') | base/logging.cc » ('j') | base/port.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698