base/port.h - Issue 7238012: Upstream android debug and log related files

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/port.h

Issue 7238012: Upstream android debug and log related files (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef BASE_PORT_H_	5 #ifndef BASE_PORT_H_

6 #define BASE_PORT_H_	6 #define BASE_PORT_H_

7 #pragma once	7 #pragma once

8	8

9 #include <stdarg.h>	9 #include <stdarg.h>

10 #include "build/build_config.h"	10 #include "build/build_config.h"

(...skipping 34 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
45 #define GG_VA_COPY(a, b) (a = b)	45 #define GG_VA_COPY(a, b) (a = b)

46 #endif	46 #endif

47	47

48 // Define an OS-neutral wrapper for shared library entry points	48 // Define an OS-neutral wrapper for shared library entry points

49 #if defined(OS_WIN)	49 #if defined(OS_WIN)

50 #define API_CALL __stdcall	50 #define API_CALL __stdcall

51 #else	51 #else

52 #define API_CALL	52 #define API_CALL

53 #endif	53 #endif

54	54

	55 #if defined(OS_ANDROID)

	56 #include <ctype.h>
	brettw 2011/06/24 22:23:57 What's this for? What's this for? michaelbai 2011/06/24 23:30:44 It is for tolower isspace etc. I can not figure ou Show quoted text On 2011/06/24 22:23:57, brettw wrote: > What's this for? It is for tolower isspace etc. I can not figure out why other platform doesn't need it. It might related Android platform. thought? brettw 2011/06/25 00:07:19 Seems like we should be adding the ctype includes Seems like we should be adding the ctype includes to the files that don't compile. Anybody that uses tolower/isspace without including it is wrong. michaelbai 2011/06/28 18:02:10 It seemed that I have to change too many files and Show quoted text On 2011/06/25 00:07:19, brettw wrote: > Seems like we should be adding the ctype includes to the files that don't > compile. Anybody that uses tolower/isspace without including it is wrong. It seemed that I have to change too many files and addd #if defined(OS_ANDROID), If the port.h is not the right place, How about move it to basictypes.h? brettw 2011/06/29 16:38:36 I really don't think ctype.h should be in any comm I really don't think ctype.h should be in any common file, and we should fix the callers to include it properly. Although it may be a number of files, I doubt doing that patch is very difficult. michaelbai 2011/07/06 18:05:52 Done. Show quoted text On 2011/06/29 16:38:36, brettw wrote: > I really don't think ctype.h should be in any common file, and we should fix the > callers to include it properly. Although it may be a number of files, I doubt > doing that patch is very difficult. Done.
	57 #endif

	58

55 #endif // BASE_PORT_H_	59 #endif // BASE_PORT_H_

OLD	NEW

« base/logging.h ('K') | « base/logging.cc ('k') | base/system_monitor/system_monitor_android.cc » ('j') | no next file with comments »