Issue 7237050: Implement Object.getOwnPropertyDescriptor for proxies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7237050: Implement Object.getOwnPropertyDescriptor for proxies. (Closed)

Created:
9 years, 5 months ago by rossberg

Modified:
9 years, 5 months ago

Reviewers:
Kevin Millikin (Chromium), Mads Ager (chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Implement Object.getOwnPropertyDescriptor for proxies. Fix bug in compilation of calls with proxy receivers. R=kmillikin@chromium.org,ager@chromium.org BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=8630

Patch Set 1 #

Total comments: 2

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+196 lines, -9 lines)			Patch
M	src/property.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/proxy.js	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/v8natives.js	View	4 chunks	+27 lines, -2 lines	2 comments	Download
M	test/mjsunit/harmony/proxies.js	View	9 chunks	+161 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

LGTM, with the same comments as the subset of this change already reviewed. http://codereview.chromium.org/7237050/diff/1/src/v8natives.js File ...

9 years, 5 months ago (2011-07-12 13:45:42 UTC) #2

rossberg

9 years, 5 months ago (2011-07-15 08:48:38 UTC) #3

http://codereview.chromium.org/7237050/diff/1/src/v8natives.js
File src/v8natives.js (right):

http://codereview.chromium.org/7237050/diff/1/src/v8natives.js#newcode634
src/v8natives.js:634: var descriptor = getOwnProperty.call(handler, p);
On 2011/07/12 13:45:42, Mads Ager wrote:
> Want to rely on Function.prototype.call which can be overwritten?

Done.

Expand Messages | Collapse Messages