Issue 7237044: Make PP_TimeTicks actually be a tick counter rather than be the same as the

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7237044: Make PP_TimeTicks actually be a tick counter rather than be the same as the (Closed)

Created:
9 years, 5 months ago by brettw

Modified:
9 years, 5 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Make PP_TimeTicks actually be a tick counter rather than be the same as the wall clock time. TEST=none BUG=57448 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91860

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+171 lines, -34 lines)			Patch
M	webkit/glue/webkit_glue.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	webkit/plugins/ppapi/event_conversion.cc	View		6 chunks	+7 lines, -8 lines	0 comments	Download
M	webkit/plugins/ppapi/file_callbacks.cc	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	webkit/plugins/ppapi/plugin_module.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/plugins/ppapi/plugin_module.cc	View		1 chunk	+4 lines, -7 lines	0 comments	Download
M	webkit/plugins/ppapi/ppb_file_io_impl.cc	View		3 chunks	+8 lines, -7 lines	0 comments	Download
M	webkit/plugins/ppapi/ppb_file_ref_impl.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	webkit/plugins/ppapi/ppb_flash_file_impl.cc	View		3 chunks	+7 lines, -6 lines	0 comments	Download
M	webkit/plugins/ppapi/ppb_flash_impl.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
A	webkit/plugins/ppapi/time_conversion.h	View		1 chunk	+29 lines, -0 lines	0 comments	Download
A	webkit/plugins/ppapi/time_conversion.cc	View		1 chunk	+51 lines, -0 lines	1 comment	Download
A	webkit/plugins/ppapi/time_conversion_unittest.cc	View	1	1 chunk	+52 lines, -0 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell.gypi	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

9 years, 5 months ago (2011-07-08 16:17:25 UTC) #2

LGTM

http://codereview.chromium.org/7237044/diff/5002/webkit/plugins/ppapi/time_co...
File webkit/plugins/ppapi/time_conversion.cc (right):

http://codereview.chromium.org/7237044/diff/5002/webkit/plugins/ppapi/time_co...
webkit/plugins/ppapi/time_conversion.cc:15: // This should only be used for
WebKit times which we can't change the
We might want to look into fixing this at some point.

Expand Messages | Collapse Messages