Issue 7237039: Remove PPBoolToBool and BoolToPPBool and use PP_FromBool and PP_ToBool instead.

Issue 7237039: Remove PPBoolToBool and BoolToPPBool and use PP_FromBool and PP_ToBool instead. (Closed)

Created:
9 years, 5 months ago by brettw

Modified:
9 years, 5 months ago

Reviewers:
dmichael (off chromium)

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Remove PPBoolToBool and BoolToPPBool and use PP_FromBool and PP_ToBool instead. I will remove ppapi/cpp/common.h when I'm sure nacl doesn't need it. TEST=it compiles BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91809

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+69 lines, -92 lines)			Patch
M	ppapi/cpp/core.cc	View	1	2 chunks	+1 line, -2 lines	0 comments	Download
M	ppapi/cpp/dev/find_dev.cc	View	1	2 chunks	+4 lines, -4 lines	1 comment	Download
M	ppapi/cpp/dev/font_dev.h	View	1	1 chunk	+4 lines, -4 lines	1 comment	Download
M	ppapi/cpp/dev/font_dev.cc	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	ppapi/cpp/dev/fullscreen_dev.cc	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	ppapi/cpp/dev/scrollbar_dev.cc	View	1	2 chunks	+1 line, -2 lines	0 comments	Download
M	ppapi/cpp/dev/selection_dev.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/cpp/dev/transport_dev.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/cpp/dev/url_util_dev.cc	View	1	1 chunk	+5 lines, -5 lines	0 comments	Download
M	ppapi/cpp/dev/video_decoder_dev.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/cpp/dev/widget_dev.cc	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	ppapi/cpp/dev/zoom_dev.cc	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	ppapi/cpp/graphics_2d.cc	View	1	2 chunks	+1 line, -2 lines	0 comments	Download
M	ppapi/cpp/image_data.cc	View	1	2 chunks	+1 line, -2 lines	0 comments	Download
M	ppapi/cpp/input_event.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	ppapi/cpp/instance.cc	View	1	2 chunks	+3 lines, -5 lines	0 comments	Download
M	ppapi/cpp/module.cc	View	1	6 chunks	+5 lines, -7 lines	0 comments	Download
M	ppapi/cpp/url_loader.cc	View	1	3 chunks	+3 lines, -5 lines	0 comments	Download
M	ppapi/cpp/url_request_info.cc	View	1	4 chunks	+9 lines, -11 lines	0 comments	Download
M	ppapi/cpp/var.cc	View	1	3 chunks	+2 lines, -3 lines	0 comments	Download
M	ppapi/proxy/host_dispatcher.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/proxy/interface_proxy.h	View	1	1 chunk	+0 lines, -8 lines	0 comments	Download
M	ppapi/proxy/ppapi_param_traits.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	ppapi/proxy/ppb_core_proxy.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/proxy/ppb_flash_clipboard_proxy.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	ppapi/proxy/ppb_flash_file_proxy.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	ppapi/proxy/ppb_font_proxy.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	ppapi/proxy/ppb_var_deprecated_proxy.cc	View	1	5 chunks	+5 lines, -5 lines	0 comments	Download
M	ppapi/proxy/serialized_var.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

dmichael (off chromium)

9 years, 5 months ago (2011-07-07 22:37:03 UTC) #2

You might want to grep the PPAPI files and get rid of all the includes of
common.h now (or you'll have to do it later when you delete common.h).

o/w rubber-stamp LGTM

http://codereview.chromium.org/7237039/diff/4004/ppapi/cpp/dev/find_dev.cc
File ppapi/cpp/dev/find_dev.cc (right):

http://codereview.chromium.org/7237039/diff/4004/ppapi/cpp/dev/find_dev.cc#ne...
ppapi/cpp/dev/find_dev.cc:8: #include "ppapi/cpp/common.h"
could remove this include now

http://codereview.chromium.org/7237039/diff/4004/ppapi/cpp/dev/font_dev.h
File ppapi/cpp/dev/font_dev.h (right):

http://codereview.chromium.org/7237039/diff/4004/ppapi/cpp/dev/font_dev.h#new...
ppapi/cpp/dev/font_dev.h:11: #include "ppapi/cpp/common.h"
here too

Expand Messages | Collapse Messages