chrome/browser/download/download_history.h - Issue 7237034: sql::MetaTable.next_download_id, DownloadManager::GetNextId()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_history.h

Issue 7237034: sql::MetaTable.next_download_id, DownloadManager::GetNextId() (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: fix merge Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/download/download_history.h

diff --git a/chrome/browser/download/download_history.h b/chrome/browser/download/download_history.h

index 6d6b237be327a7190d0287c89a3848ac7dd5c19a..45f978ba024489434fb178e1ccc3ed03b388a58d 100644

--- a/chrome/browser/download/download_history.h

+++ b/chrome/browser/download/download_history.h

@@ -27,6 +27,11 @@ class DownloadHistory {

explicit DownloadHistory(Profile* profile);

~DownloadHistory();

+ // Retrieves the next_id counter from the sql meta_table.

+ // Should be much faster than Load so that we may delay downloads until after

+ // this call with minimal performance penalty.

+ void GetNextId(HistoryService::DownloadNextIdCallback* callback);

// Retrieves DownloadCreateInfos saved in the history.

void Load(HistoryService::DownloadQueryCallback* callback);