sql::MetaTable.next_download_id, DownloadManager::GetNextId()

chrome/browser/profiles/profile_io_data.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_io_data.h"
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/bind.h"
@@ skipping 173 matching lines @@
     return profile->GetPrerenderManager();
   return NULL;
 }
 
 }  // namespace
 
 void ProfileIOData::InitializeProfileParams(Profile* profile) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   PrefService* pref_service = profile->GetPrefs();
 
+  next_download_id_thunk_ = profile->GetDownloadManager()->GetNextIdThunk();
+
   scoped_ptr<ProfileParams> params(new ProfileParams);
   params->is_incognito = profile->IsOffTheRecord();
   params->clear_local_state_on_exit =
       pref_service->GetBoolean(prefs::kClearSiteDataOnExit);
 
   params->appcache_service = profile->GetAppCacheService();
 
   // Set up Accept-Language and Accept-Charset header values
   params->accept_language = net::HttpUtil::GenerateAcceptLanguageHeader(
       pref_service->GetString(prefs::kAcceptLanguages));
@@ skipping 274 matching lines @@
   resource_context_.set_database_tracker(database_tracker_);
   resource_context_.set_appcache_service(appcache_service_);
   resource_context_.set_blob_storage_context(blob_storage_context_);
   resource_context_.set_file_system_context(file_system_context_);
   resource_context_.set_quota_manager(quota_manager_);
   resource_context_.set_host_zoom_map(host_zoom_map_);
   resource_context_.set_prerender_manager_getter(prerender_manager_getter_);
   resource_context_.SetUserData(NULL, const_cast<ProfileIOData*>(this));
   resource_context_.set_media_observer(
       io_thread_globals->media.media_internals.get());
+  // TODO(benjhayden) clean this up when we can include DownloadManager in
+  // ResourceContext.
+  resource_context_.SetUserData(reinterpret_cast<void*>(BASE_HASH_NAMESPACE::

[willchan no longer on Chromium, 2011/08/06 14:08:36]

Don't use SetUserData() for this. Create a new setter / accessor for it. void*
lookup tricks are only useful when you want to abstract out the dependencies
between layers. Higher layers may set a void*, and when the lower layer calls
into the higher layer, the higher layer might "know" that the void* corresponds
to a T*, and can safely cast to T*. In this case, content/ is the lower layer
and content/ needs to know the concrete type T anyway, so this gains us nothing.
So, it's better to just use specific setters/getters and thus allow static type
checking to help us.

[benjhayden, 2011/08/08 16:50:19]

Sorry, are you suggesting having content/browser/resource_context.h include
chrome/browser/download/download_manager.h so that ResourceContext can contain a
GetNextIdThunkType, or having a void* field in ResourceContext?

[willchan no longer on Chromium, 2011/08/10 01:24:20]

I'm suggesting including the necessary header.

I'm not sure if I'm reading too much into your question, but I suspect you may
be concerned that this creates an undesirable dependency from ResourceContext
onto chrome/. If so, don't worry about this specific instance. You would be
correct to worry about content/ depending on chrome/. However,
download_manager.h is still being used by content/, in ResourceDispatcherHost.
It sounds from the earlier messages by rdsmith in this thread that
DownloadManager will need to move into content/. If so, this isn't a bad
dependency. If DownloadManager doesn't need to move into content/, then at the
time that DownloadManager gets removed from ResourceDispatcherHost, this
dependency here will need to be removed from ResourceContext.

[benjhayden, 2011/08/16 19:54:15]

Done.

+#if defined(COMPILER_GCC)
+      hash<std::string>()
+#elif defined(COMPILER_MSVC)
+      hash_value
+#endif
+      ("next_download_id_thunk")), &next_download_id_thunk_);
 
   LazyInitializeInternal(profile_params_.get());
 
   profile_params_.reset();
   initialized_ = true;
 }
 
 void ProfileIOData::ApplyProfileParamsToContext(
     ChromeURLRequestContext* context) const {
   context->set_is_incognito(profile_params_->is_incognito);
@@ skipping 14 matching lines @@
       BrowserThread::IO, FROM_HERE,
       base::Bind(
           &ResourceDispatcherHost::CancelRequestsForContext,
           base::Unretained(g_browser_process->resource_dispatcher_host()),
           &resource_context_));
   bool posted = BrowserThread::PostTask(BrowserThread::IO, FROM_HERE,
                                         new DeleteTask<ProfileIOData>(this));
   if (!posted)
     delete this;
 }