sql::MetaTable.next_download_id, DownloadManager::GetNextId()

content/browser/renderer_host/resource_dispatcher_host.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // See http://dev.chromium.org/developers/design-documents/multi-process-resource-loading
 
 #include "content/browser/renderer_host/resource_dispatcher_host.h"
 
 #include <set>
 #include <vector>
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop.h"
 #include "base/metrics/histogram.h"
 #include "base/shared_memory.h"
 #include "base/stl_util.h"
 #include "base/time.h"
 #include "chrome/browser/download/download_file_manager.h"
 #include "chrome/browser/download/download_manager.h"
 #include "chrome/browser/download/download_request_limiter.h"
 #include "chrome/browser/download/download_util.h"
+#include "chrome/browser/profiles/profile_io_data.h"
 #include "chrome/browser/renderer_host/download_resource_handler.h"
 #include "content/browser/appcache/chrome_appcache_service.h"
 #include "content/browser/cert_store.h"
 #include "content/browser/child_process_security_policy.h"
 #include "content/browser/chrome_blob_storage_context.h"
 #include "content/browser/content_browser_client.h"
 #include "content/browser/cross_site_request_manager.h"
 #include "content/browser/download/save_file_manager.h"
 #include "content/browser/download/save_file_resource_handler.h"
 #include "content/browser/in_process_webkit/webkit_thread.h"
@@ skipping 661 matching lines @@
 
   BrowserThread::PostTask(
       BrowserThread::UI, FROM_HERE,
       NewRunnableFunction(&download_util::NotifyDownloadInitiated,
                           child_id, route_id));
 
   net::URLRequest* request = new net::URLRequest(url, this);
 
   request_id_--;
 
+  ProfileIOData* profile_io_data = reinterpret_cast<ProfileIOData*>(

[willchan no longer on Chromium, 2011/07/23 09:41:07]

content/ is not allowed to depend on chrome/, so you can't use ProfileIOData
directly in content/. The content interface to stuff in ProfileIOData is
ResourceContext. But it's only allowed to expose an interface for content/. My
hunch is something like a GetNextIdThunkType is an implementation detail of
chrome/ and not something that jam@ would want exposed at the content/ level.
You should probably ask him. I don't really know how much of the download
subsystem is needed in the content/ level and how much should live in the
chrome/ level. Definitely all the UI components belong in the chrome/ level.
Anyhow, my suspicion is that the "correct" layering solution is to expose an
interface in ResourceContext that is a DownloadHandlerFactory or something that
produces ResourceHandlers. This DownloadHandlerFactory's implementation in
Chrome would be constructed with this GetNextIdThunkType (and probably also the
DownloadFileManager since I don't think that belongs in content/).

That's just my quick inkling of how this "should" work. You should check with
jam@.

[Randy Smith (Not in Mondays), 2011/07/25 20:20:12]

In the absence of commentary from jam, I'll go with my understanding of Will's
description and jam's plans, and say this should be in ResourceContext.

[benjhayden, 2011/07/27 19:40:54]

DownloadManager is moving to content/. Could a GetNextIdThunkType live in
ProfileIOData once that is done?

[benjhayden, 2011/07/27 19:40:54]

Even though DownloadManager is moving to content/?

[willchan no longer on Chromium, 2011/07/27 19:47:14]

I don't see how DownloadManager moving to content/ is relevant here. content/ is
not allowed to depend on anything in chrome/. In particular, it's not allowed to
depend on Profile&ProfileIOData, as those will always be in chrome/. It doesn't
matter if DownloadManager is moving to content/, Profile&ProfileIOData aren't
moving to content/, so you can't depend on ProfileIOData from content/.

Can't depend on ProfileIOData in content/ :)

[benjhayden, 2011/07/28 15:37:52]

Done.

+      context.GetUserData(NULL));
+  const DownloadManager::GetNextIdThunkType& get_next_id =
+      profile_io_data->next_download_id_thunk();
+
   scoped_refptr<ResourceHandler> handler(
       new DownloadResourceHandler(this,
                                   child_id,
                                   route_id,
                                   request_id_,
                                   url,
+                                  get_next_id,
                                   download_file_manager_.get(),
                                   request,
                                   prompt_for_save_location,
                                   save_info));
 
   if (delegate_) {
     handler = delegate_->DownloadStarting(handler, context, child_id,
                                           route_id);
   }
 
   const net::URLRequestContext* request_context = context.request_context();
 
   if (!request_context->job_factory()->IsHandledURL(url)) {
     VLOG(1) << "Download request for unsupported protocol: "
             << url.possibly_invalid_spec();
     return;
   }
 
   request->set_method("GET");
   request->set_referrer(MaybeStripReferrer(referrer).spec());
-  request->set_context(context.request_context());
+  request->set_context(request_context);
   request->set_load_flags(request->load_flags() |
       net::LOAD_IS_DOWNLOAD);
 
   ResourceDispatcherHostRequestInfo* extra_info =
       CreateRequestInfoForBrowserRequest(
           handler, child_id, route_id, true, context);
   SetRequestInfo(request, extra_info);  // Request takes ownership.
 
   BeginRequestInternal(request);
 }
@@ skipping 1342 matching lines @@
   return HTTP_AUTH_RESOURCE_BLOCKED_CROSS;
 }
 
 bool ResourceDispatcherHost::allow_cross_origin_auth_prompt() {
   return allow_cross_origin_auth_prompt_;
 }
 
 void ResourceDispatcherHost::set_allow_cross_origin_auth_prompt(bool value) {
   allow_cross_origin_auth_prompt_ = value;
 }