Issue 7237032: Changes wrench menu button to show system menu on space. This matches

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7237032: Changes wrench menu button to show system menu on space. This matches (Closed)

Created:
9 years, 5 months ago by sky

Modified:
9 years, 5 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Changes wrench menu button to show system menu on space. This matches what windows does. BUG=56650 TEST=press alt and release, focus should be on the wrench. press space, make sure the window menu appears, not the wrench menu. R=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91805

Patch Set 1 #

Patch Set 2 : Moved to hwnd_util #

Total comments: 1

Patch Set 3 : Tweak comment #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+71 lines, -7 lines)			Patch
A	chrome/browser/ui/views/app_menu_button_win.h	View		1 chunk	+24 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/views/app_menu_button_win.cc	View	1	1 chunk	+23 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/toolbar_view.cc	View		2 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	ui/base/win/hwnd_util.h	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	ui/base/win/hwnd_util.cc	View	1	2 chunks	+12 lines, -0 lines	0 comments	Download
M	views/widget/native_widget_win.cc	View	1	1 chunk	+1 line, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

9 years, 5 months ago (2011-07-07 21:25:44 UTC) #3

LGTM

http://codereview.chromium.org/7237032/diff/2002/ui/base/win/hwnd_util.h
File ui/base/win/hwnd_util.h (right):

http://codereview.chromium.org/7237032/diff/2002/ui/base/win/hwnd_util.h#newc...
ui/base/win/hwnd_util.h:47: // Shows the system menu for |window|.
... and sends the selected command to it.

Expand Messages | Collapse Messages