Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 7237031: Revert 89600 - Treat ERR_CONNECTION_CLOSED as a succesful download. (Closed)

Created:
9 years, 5 months ago by ahendrickson
Modified:
9 years, 5 months ago
CC:
chromium-reviews, rdsmith+dwatch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert 89600 - Treat ERR_CONNECTION_CLOSED as a succesful download. ========================= Note: This revert is only temporary, to collect statistics for how frequently this case is encountered in the wild. This will be re-reverted shortly. ========================= Some servers will send a Content-Length which exceeds the number of bytes sent in the message body. Although this violates the RFC spec, other major browsers permit it and treat a download as complete in that case. Chrome did as well prior to M12, and now some users are unable to access the item that they downloaded. Attempt #2. BUG=85549 TEST=Go to server which advertises larger Content-Length than number of bytes sent, confirm that the download is no longer reported as interrupted. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91769

Patch Set 1 #

Patch Set 2 : Reverted experiment to gather statistics on ERR_CONNECTION_CLOSED occurrences. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M chrome/browser/download/download_manager.cc View 1 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ahendrickson
9 years, 5 months ago (2011-07-07 19:23:28 UTC) #1
Randy Smith (Not in Mondays)
LGTM.
9 years, 5 months ago (2011-07-07 21:02:52 UTC) #2
commit-bot: I haz the power
9 years, 5 months ago (2011-07-07 22:14:17 UTC) #3
Change committed as 91769

Powered by Google App Engine
This is Rietveld 408576698