Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Unified Diff: chrome/test/test_tab_strip_model_observer.h

Issue 7237030: Added options browser_tests using the generator and js handler framework. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added documentation for newly added classes. Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/test_tab_strip_model_observer.h
diff --git a/chrome/test/test_tab_strip_model_observer.h b/chrome/test/test_tab_strip_model_observer.h
index a41e5dfed2aec4a56ef72a668569c343df80ce7f..e5a159368a4d2bea5de6b20784a41b1eb439a4cf 100644
--- a/chrome/test/test_tab_strip_model_observer.h
+++ b/chrome/test/test_tab_strip_model_observer.h
@@ -8,8 +8,7 @@
#include "base/compiler_specific.h"
#include "chrome/browser/tabs/tab_strip_model_observer.h"
-#include "content/common/notification_observer.h"
-#include "content/common/notification_registrar.h"
+#include "chrome/test/test_navigation_observer.h"
class TabStripModel;
@@ -20,60 +19,24 @@ class TabStripModel;
// javascript before the webui page loads by calling back through the
// TestTabStripModelObserver::LoadStartObserver when the new page starts
// loading.
-class TestTabStripModelObserver : public TabStripModelObserver,
- public NotificationObserver {
+class TestTabStripModelObserver : public TestNavigationObserver,
+ public TabStripModelObserver {
public:
- class LoadStartObserver {
- public:
- LoadStartObserver();
- virtual ~LoadStartObserver();
-
- // Called to indicate page load starting.
- virtual void OnLoadStart() = 0;
- };
-
// Observe the |tab_strip_model|, which may not be NULL. If
// |load_start_observer| is non-NULL, notify when the page load starts.
TestTabStripModelObserver(TabStripModel* tab_strip_model,
LoadStartObserver* load_start_observer);
virtual ~TestTabStripModelObserver();
- // Run the UI message loop until |done_| becomes true.
- void WaitForObservation();
-
private:
// TabStripModelObserver:
virtual void TabInsertedAt(TabContentsWrapper* contents, int index,
bool foreground) OVERRIDE;
- // NotificationObserver:
- virtual void Observe(NotificationType type, const NotificationSource& source,
- const NotificationDetails& details) OVERRIDE;
-
- NotificationRegistrar registrar_;
-
- // If true the navigation has started.
- bool navigation_started_;
-
- // The number of navigations that have been completed.
- int navigations_completed_;
-
- // The number of navigations to wait for.
- int number_of_navigations_;
-
// |tab_strip_model_| is the object this observes. The constructor will
// register this as an observer, and the destructor will remove the observer.
TabStripModel* tab_strip_model_;
- // Observer to take some action when the page load starts.
- LoadStartObserver* load_start_observer_;
-
- // |done_| will get set when this object observes a TabStripModel event.
- bool done_;
-
- // |running_| will be true during WaitForObservation until |done_| is true.
- bool running_;
-
DISALLOW_COPY_AND_ASSIGN(TestTabStripModelObserver);
};

Powered by Google App Engine
This is Rietveld 408576698