Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1162)

Unified Diff: chrome/browser/ui/webui/print_preview_browsertest.cc

Issue 7237030: Added options browser_tests using the generator and js handler framework. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: s/settings/options/, moved .cc into options dir, addressed JS readability. Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/print_preview_browsertest.cc
diff --git a/chrome/browser/ui/webui/print_preview_browsertest.cc b/chrome/browser/ui/webui/print_preview_browsertest.cc
index a288956d73420fdc398cff154fed60b3d24ab220..73c3e9bb33a47d008834fc3d453da5a56cbf4b7f 100644
--- a/chrome/browser/ui/webui/print_preview_browsertest.cc
+++ b/chrome/browser/ui/webui/print_preview_browsertest.cc
@@ -34,8 +34,7 @@ void PrintAndWaitForPrintPreviewTab(
} // namespace
class PrintPreviewWebUITest
- : public WebUIBrowserTest,
- public TestTabStripModelObserver::LoadStartObserver {
+ : public WebUIBrowserTest {
protected:
// WebUIBrowserTest:
virtual void SetUpOnMainThread() OVERRIDE {
@@ -43,6 +42,7 @@ class PrintPreviewWebUITest
if (!HasPDFLib())
skipTest(base::StringPrintf("%s:%d: No PDF Lib.", __FILE__, __LINE__));
+ override_chrome_send_ = true;
AddLibrary(FilePath(FILE_PATH_LITERAL("print_preview.js")));
GURL print_preview_test_url = WebUITestDataPathToURL(
FILE_PATH_LITERAL("print_preview_hello_world_test.html"));
@@ -60,11 +60,6 @@ class PrintPreviewWebUITest
#endif
}
- // TestTabStripModelObserver::LoadStartObserver:
- virtual void OnLoadStart() OVERRIDE {
- PreLoadJavascriptLibraries(true);
- }
-
bool HasPDFLib() const {
FilePath pdf;
return PathService::Get(chrome::FILE_PDF_PLUGIN, &pdf) &&

Powered by Google App Engine
This is Rietveld 408576698