Added options browser_tests using the generator and js handler framework.

chrome/browser/ui/webui/web_ui_browsertest.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_WEBUI_WEB_UI_BROWSERTEST_H_
 #define CHROME_BROWSER_UI_WEBUI_WEB_UI_BROWSERTEST_H_
 #pragma once
 
 #include <string>
 
 #include "base/file_path.h"
 #include "chrome/browser/ui/webui/web_ui_test_handler.h"
 #include "chrome/test/in_process_browser_test.h"
+#include "chrome/test/test_navigation_observer.h"
 
 class Value;
 class WebUIMessageHandler;
 
 // This macro simplifies the declaration of simple javascript unit tests.
 // Use:
 //   WEB_UI_UNITTEST_F(MyWebUIPageTest, myJavascriptUnittest);
 #define WEB_UI_UNITTEST_F(x, y) \
   IN_PROC_BROWSER_TEST_F(x, y) { \
     ASSERT_TRUE(RunJavascriptTest(#y)); \
   }
 
 // The runner of WebUI javascript based tests.
 // See chrome/test/data/webui/test_api.js for the javascript side test API's.
 //
 // These tests should follow the form given in:
 // chrome/test/data/webui/sample_downloads.js.
 // and the lone test within this class.
-class WebUIBrowserTest : public InProcessBrowserTest {
+class WebUIBrowserTest : public InProcessBrowserTest,
+                         public TestNavigationObserver::LoadStartObserver {
  public:
   typedef std::vector<const Value*> ConstValueVector;
   virtual ~WebUIBrowserTest();
 
   // Add a custom helper JS library for your test.
   // If a relative path is specified, it'll be read
   // as relative to the test data dir.
   void AddLibrary(const FilePath& library_path);
 
   // Runs a javascript function in the context of all libraries.
@@ skipping 16 matching lines @@
                          const Value& arg2);
   bool RunJavascriptTest(const std::string& test_name,
                          const ConstValueVector& test_arguments);
 
   // Preloads the javascript libraries and sets the |libraries_preloaded| flag
   // to prevent re-loading at next javascript invocation. If
   // |override_chrome_send| is true, then chrome.send is overridden for
   // javascript to register handlers.
   void PreLoadJavascriptLibraries(bool override_chrome_send);
 
+  // Called by javascript-generated test bodies to browse to a page and preload
+  // the javascript. chrome.send will be overridden if |override_chrome_send| is
+  // set.
+  void BrowsePreload(const GURL& browse_to, bool override_chrome_send);
+
+  // Saves the state of |override_chrome_send| for calling
+  // PreloadJavascriptLibraries().
+  bool override_chrome_send_;

[James Hawkins, 2011/07/08 00:03:33]

Shouldn't this be protected?

[Sheridan Rawlins, 2011/07/08 22:45:49]

Replacements (preload_test_fixture_, preload_test_name_) are now protected.

On 2011/07/08 00:03:33, James Hawkins wrote:

+
  protected:
   WebUIBrowserTest();
 
   // Setup test path.
   virtual void SetUpInProcessBrowserTestFixture();
 
   // Returns a mock WebUI object under test (if any).
   virtual WebUIMessageHandler* GetMockMessageHandler();
 
   // Skip this test with |skip_test_message|.
   void skipTest(const std::string& skip_test_message);
 
   // Returns a file:// GURL constructed from |path| inside the test data dir for
   // webui tests.
   static GURL WebUITestDataPathToURL(const FilePath::StringType& path);
 
  private:
+  // TestNavigationObserver::LoadStartObserver:

[James Hawkins, 2011/07/08 00:03:33]

// TestNavigationObserver::LoadStartObserver implementation.

[Sheridan Rawlins, 2011/07/08 22:45:49]

Done.

+  virtual void OnLoadStart() OVERRIDE;
+
   // Builds a string containing all added javascript libraries.
   void BuildJavascriptLibraries(std::string* content);
 
   // Builds a string with a call to the runTest JS function, passing the
   // given test and its arguments.
   string16 BuildRunTestJSCall(const std::string& test_name,
                               const WebUIBrowserTest::ConstValueVector& args);
 
   // Calls the specified function with all libraries available. If |is_test|
   // is true, the framework listens for pass fail messages from javascript.
@@ skipping 16 matching lines @@
 
   // Indicates that the libraries have been pre-loaded and to not load them
   // again.
   bool libraries_preloaded_;
 
   bool skip_test_;
   std::string skip_test_message_;
 };
 
 #endif  // CHROME_BROWSER_UI_WEBUI_WEB_UI_BROWSERTEST_H_