Issue 7237025: Updating Extension infobars to account for changes...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7237025: Updating Extension infobars to account for changes... (Closed)

Created:
9 years, 6 months ago by Finnur

Modified:
9 years, 6 months ago

Reviewers:
asargent_no_longer_on_chrome

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Updating Extension infobars to account for changes in the Native infobars (they grew an arrow, changing the available view surface) and changed its background. So the Extension Host drew outside its boundaries and had a blue background instead of gray. That is now fixed. BUG=85689 TEST=Make sure infobars look good and don't paint outside their allocated space. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90550

Patch Set 1 #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	chrome/browser/resources/extensions_infobar.css	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/browser/ui/views/infobars/extension_infobar.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages