Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(662)

Issue 7237004: Trim fast elements tail on significant length decreases. (Closed)

Created:
9 years, 6 months ago by Vitaly Repeshko
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Trim fast elements tail on significant length decreases. Runtime_RegExpExecMultiple had to be updated because it assumed setting an array's length to zero still keeps some capacity in the backing store. R=ager@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=8396

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -7 lines) Patch
M src/objects.cc View 1 chunk +18 lines, -6 lines 0 comments Download
M src/runtime.cc View 1 chunk +2 lines, -1 line 2 comments Download

Messages

Total messages: 3 (0 generated)
Vitaly Repeshko
9 years, 6 months ago (2011-06-22 21:59:10 UTC) #1
Mads Ager (chromium)
LGTM http://codereview.chromium.org/7237004/diff/1/src/runtime.cc File src/runtime.cc (right): http://codereview.chromium.org/7237004/diff/1/src/runtime.cc#newcode3536 src/runtime.cc:3536: if (result_elements.is_null() || result_elements->length() < 16) { Is ...
9 years, 6 months ago (2011-06-23 06:37:04 UTC) #2
Mads Ager (chromium)
9 years, 6 months ago (2011-06-23 08:54:08 UTC) #3
http://codereview.chromium.org/7237004/diff/1/src/runtime.cc
File src/runtime.cc (right):

http://codereview.chromium.org/7237004/diff/1/src/runtime.cc#newcode3536
src/runtime.cc:3536: if (result_elements.is_null() || result_elements->length()
< 16) {
On 2011/06/23 06:37:04, Mads Ager wrote:
> Is this an unrelated change?

Nevermind, just read the change description. :-)

Powered by Google App Engine
This is Rietveld 408576698