Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Side by Side Diff: src/mips/macro-assembler-mips.cc

Issue 7236024: MIPS: Fix a bug in MacroAssembler::CheckFastElements. (Closed)
Patch Set: Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2639 matching lines...) Expand 10 before | Expand all | Expand 10 after
2650 Subu(length, length, Operand(1)); 2650 Subu(length, length, Operand(1));
2651 Branch(&byte_loop_1, ne, length, Operand(zero_reg)); 2651 Branch(&byte_loop_1, ne, length, Operand(zero_reg));
2652 bind(&done); 2652 bind(&done);
2653 } 2653 }
2654 2654
2655 2655
2656 void MacroAssembler::CheckFastElements(Register map, 2656 void MacroAssembler::CheckFastElements(Register map,
2657 Register scratch, 2657 Register scratch,
2658 Label* fail) { 2658 Label* fail) {
2659 STATIC_ASSERT(JSObject::FAST_ELEMENTS == 0); 2659 STATIC_ASSERT(JSObject::FAST_ELEMENTS == 0);
2660 lbu(scratch, FieldMemOperand(map, Map::kBitField2Offset)); 2660 lbu(scratch, FieldMemOperand(map, Map::kInstanceTypeOffset));
2661 And(scratch, scratch, Operand(Map::kMaximumBitField2FastElementValue)); 2661 Branch(fail, hi, scratch, Operand(Map::kMaximumBitField2FastElementValue));
2662 Branch(fail, hi, scratch, Operand(zero_reg));
2663 } 2662 }
2664 2663
2665 2664
2666 void MacroAssembler::CheckMap(Register obj, 2665 void MacroAssembler::CheckMap(Register obj,
2667 Register scratch, 2666 Register scratch,
2668 Handle<Map> map, 2667 Handle<Map> map,
2669 Label* fail, 2668 Label* fail,
2670 SmiCheckType smi_check_type) { 2669 SmiCheckType smi_check_type) {
2671 if (smi_check_type == DO_SMI_CHECK) { 2670 if (smi_check_type == DO_SMI_CHECK) {
2672 JumpIfSmi(obj, fail); 2671 JumpIfSmi(obj, fail);
(...skipping 1434 matching lines...) Expand 10 before | Expand all | Expand 10 after
4107 opcode == BGTZL); 4106 opcode == BGTZL);
4108 opcode = (cond == eq) ? BEQ : BNE; 4107 opcode = (cond == eq) ? BEQ : BNE;
4109 instr = (instr & ~kOpcodeMask) | opcode; 4108 instr = (instr & ~kOpcodeMask) | opcode;
4110 masm_.emit(instr); 4109 masm_.emit(instr);
4111 } 4110 }
4112 4111
4113 4112
4114 } } // namespace v8::internal 4113 } } // namespace v8::internal
4115 4114
4116 #endif // V8_TARGET_ARCH_MIPS 4115 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698