Manage gpu feature capabilities through blacklist indepedently.

Manage gpu feature capabilities through blacklist indepedently.

Add entry to disable acclerated-compositing and accelerated-2d-canvas for Mac Leopard.  Also, don't disallow all GPU features if accelerated-composting is disabled: managing each feature through SRL.

BUG=87157
TEST=unittest, about:gpu reports correctly GPU feature states on Mac Leopard.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90831

[Zhenyao Mo, 2011-06-24 02:12:51]

Please review.

[vangelis, 2011-06-27 17:43:16]

http://codereview.chromium.org/7236023/diff/4001/chrome/browser/resources/sof...
File chrome/browser/resources/software_rendering_list.json (right):

http://codereview.chromium.org/7236023/diff/4001/chrome/browser/resources/sof...
chrome/browser/resources/software_rendering_list.json:249: "description": "Mac
Leopard does not support accelerated_2d_canvas and accelerated_compositing.",
nit: replace "Leopard" by "OSX 10.5" as I think few people know the OS version
by that name.

nit #2: It might be more clear to say:

"Accelerated 2D canvas and accelerated compositing are not supported in Mac OSX
version 10.5"

http://codereview.chromium.org/7236023/diff/4001/chrome/browser/resources/sof...
chrome/browser/resources/software_rendering_list.json:255: "number": "10.5"
Will this catch version 10.5.x which is most likely the version reported?

http://codereview.chromium.org/7236023/diff/4001/chrome/browser/resources/sof...
chrome/browser/resources/software_rendering_list.json:260:
"accelerated_compositing"
Isn't accelerated canvas disabled automatically when accelerated compositing is
off?

[Zhenyao Mo, 2011-06-27 20:24:21]

http://codereview.chromium.org/7236023/diff/4001/chrome/browser/resources/sof...
File chrome/browser/resources/software_rendering_list.json (right):

http://codereview.chromium.org/7236023/diff/4001/chrome/browser/resources/sof...
chrome/browser/resources/software_rendering_list.json:249: "description": "Mac
Leopard does not support accelerated_2d_canvas and accelerated_compositing.",
On 2011/06/27 17:43:16, vangelis wrote:
> nit: replace "Leopard" by "OSX 10.5" as I think few people know the OS version
> by that name.
> 
> nit #2: It might be more clear to say:
> 
> "Accelerated 2D canvas and accelerated compositing are not supported in Mac
OSX
> version 10.5"

Done.

http://codereview.chromium.org/7236023/diff/4001/chrome/browser/resources/sof...
chrome/browser/resources/software_rendering_list.json:255: "number": "10.5"
On 2011/06/27 17:43:16, vangelis wrote:
> Will this catch version 10.5.x which is most likely the version reported?  

Yes, it will catch 10.5 or 10.5.*

http://codereview.chromium.org/7236023/diff/4001/chrome/browser/resources/sof...
chrome/browser/resources/software_rendering_list.json:260:
"accelerated_compositing"
On 2011/06/27 17:43:16, vangelis wrote:
> Isn't accelerated canvas disabled automatically when accelerated compositing
is
> off? 

I feel by not having this dependency logic we have more flexibility in the
future.

[Zhenyao Mo, 2011-06-27 20:25:46]

Updated.  Please have a look again.

[vangelis, 2011-06-27 21:09:50]

Just one comment, otherwise LGTM.

http://codereview.chromium.org/7236023/diff/9001/chrome/browser/resources/sof...
File chrome/browser/resources/software_rendering_list.json (right):

http://codereview.chromium.org/7236023/diff/9001/chrome/browser/resources/sof...
chrome/browser/resources/software_rendering_list.json:249: "description":
"Accelerated_2d_canvas and accelerated_compositing are not supported in Mac OSX
version 10.5",
Do we need the underscores between the words?  This is a user-facing message.

[Zhenyao Mo, 2011-06-27 21:24:06]

http://codereview.chromium.org/7236023/diff/9001/chrome/browser/resources/sof...
File chrome/browser/resources/software_rendering_list.json (right):

http://codereview.chromium.org/7236023/diff/9001/chrome/browser/resources/sof...
chrome/browser/resources/software_rendering_list.json:249: "description":
"Accelerated_2d_canvas and accelerated_compositing are not supported in Mac OSX
version 10.5",
On 2011/06/27 21:09:50, vangelis wrote:
> Do we need the underscores between the words?  This is a user-facing message.

Will fix this in the landing CL.

[Zhenyao Mo, 2011-06-27 21:31:19]

Ah, Al, do you mind rubber stamping this one?  Vangelis is not an owner for
gpu_data_manager.cc

[apatrick_chromium, 2011-06-28 20:36:30]

LGTM