Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 7235023: Mac: Split SystemMonitor initialization so it's not blocked by the Sandbox. (Closed)

Created:
9 years, 6 months ago by jeremy
Modified:
9 years, 5 months ago
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

Mac: Split SystemMonitor initialization so it's not blocked by the Sandbox. In OS X 10.7 Lion, the IO port we listen on to monitor system power events is blocked by the Sandbox. Move the allocation of the IO port so it happens early on during Chrome startup. BUG=83783 TEST=When putting a system to sleep with Chrome running, the browser shouldn't crash. Also, need to monitor crash logs to see that this crash goes away. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91462

Patch Set 1 #

Patch Set 2 : Rebase + make tests pass. #

Patch Set 3 : Fix Tests #

Patch Set 4 : Really Fix Tests #

Patch Set 5 : Synced to trunk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -21 lines) Patch
M base/system_monitor/system_monitor.h View 2 chunks +8 lines, -5 lines 0 comments Download
M base/system_monitor/system_monitor_mac.mm View 4 chunks +28 lines, -12 lines 0 comments Download
M base/system_monitor/system_monitor_unittest.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/app/chrome_main.cc View 1 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_event_router_forwarder_unittest.cc View 1 2 3 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_manager_unittest.cc View 1 2 3 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/tabs/tab_strip_model_unittest.cc View 1 2 3 2 chunks +7 lines, -2 lines 0 comments Download
M chrome/test/in_process_browser_test.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jeremy
FYI: The reason I initialize the IO ports in the main function and not in ...
9 years, 6 months ago (2011-06-27 10:56:24 UTC) #1
Scott Hess - ex-Googler
LGTM. base::SystemMonitor is looking pretty bizarre at this point.
9 years, 6 months ago (2011-06-27 18:05:25 UTC) #2
jeremy
Mark,Sky: Need both of you to approve as owners, rubberstamp OK.
9 years, 5 months ago (2011-06-29 08:18:49 UTC) #3
Mark Mentovai
LGTM for base approval. chrome/test/OWNERS doesn’t have “set noparent” in effect, so I think you’re ...
9 years, 5 months ago (2011-06-29 14:06:00 UTC) #4
sky
LGTM
9 years, 5 months ago (2011-06-29 14:08:38 UTC) #5
commit-bot: I haz the power
9 years, 5 months ago (2011-07-04 04:17:04 UTC) #6
Presubmit check for 7235023-12002 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
chrome/browser/profiles/profile_manager_unittest.cc

Powered by Google App Engine
This is Rietveld 408576698