plugins/org.chromium.debug.core/src/org/chromium/debug/core/model/VmResourceId.java - Issue 7235005: Add intermediate VmResourceRef for inaccurate source lookup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: plugins/org.chromium.debug.core/src/org/chromium/debug/core/model/VmResourceId.java

Issue 7235005: Add intermediate VmResourceRef for inaccurate source lookup (Closed) Base URL: https://chromedevtools.googlecode.com/svn/trunk

Patch Set: clean Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « plugins/org.chromium.debug.core/src/org/chromium/debug/core/model/VProjectWorkspaceBridge.java ('k') | plugins/org.chromium.debug.core/src/org/chromium/debug/core/model/VmResourceRef.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: plugins/org.chromium.debug.core/src/org/chromium/debug/core/model/VmResourceId.java

diff --git a/plugins/org.chromium.debug.core/src/org/chromium/debug/core/model/VmResourceId.java b/plugins/org.chromium.debug.core/src/org/chromium/debug/core/model/VmResourceId.java

index cd1cb89eb1776afd9a2c141a2babf40362604718..c47336eb1ae347d378f7efca447a78f4bfe3ebb2 100644

--- a/plugins/org.chromium.debug.core/src/org/chromium/debug/core/model/VmResourceId.java

+++ b/plugins/org.chromium.debug.core/src/org/chromium/debug/core/model/VmResourceId.java

@@ -5,7 +5,6 @@

package org.chromium.debug.core.model;

import org.chromium.debug.core.util.ChromiumDebugPluginUtil;

-import org.chromium.sdk.Breakpoint;

import org.chromium.sdk.Script;

/**

@@ -58,18 +57,6 @@ public class VmResourceId {

return "<" + name + " : " + id + ">";

}

- /**

- * @return parameter for {@link JavascriptVm#setBreakpoint} method.

- */

- public Breakpoint.Target getTargetForBreakpoint() {

- if (name != null) {

- return new Breakpoint.Target.ScriptName(name);

- } else {

- return new Breakpoint.Target.ScriptId(id);

- }

public String getVisibleName() {

String name = getName();

if (name != null) {