Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: plugins/org.chromium.debug.core/src/org/chromium/debug/core/ChromiumSourceDirector.java

Issue 7235005: Add intermediate VmResourceRef for inaccurate source lookup (Closed) Base URL: https://chromedevtools.googlecode.com/svn/trunk
Patch Set: clean Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | plugins/org.chromium.debug.core/src/org/chromium/debug/core/model/BreakpointSynchronizer.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: plugins/org.chromium.debug.core/src/org/chromium/debug/core/ChromiumSourceDirector.java
diff --git a/plugins/org.chromium.debug.core/src/org/chromium/debug/core/ChromiumSourceDirector.java b/plugins/org.chromium.debug.core/src/org/chromium/debug/core/ChromiumSourceDirector.java
index e9e476848620632d569fde1999b735a7b7e830b1..e97b3f22b1d96c55dd970a79dd0d020b760a15b8 100644
--- a/plugins/org.chromium.debug.core/src/org/chromium/debug/core/ChromiumSourceDirector.java
+++ b/plugins/org.chromium.debug.core/src/org/chromium/debug/core/ChromiumSourceDirector.java
@@ -10,6 +10,7 @@ import org.chromium.debug.core.model.ResourceManager;
import org.chromium.debug.core.model.StackFrame;
import org.chromium.debug.core.model.VmResource;
import org.chromium.debug.core.model.VmResourceId;
+import org.chromium.debug.core.model.VmResourceRef;
import org.chromium.sdk.Breakpoint;
import org.chromium.sdk.BreakpointTypeExtension;
import org.chromium.sdk.Script;
@@ -34,6 +35,14 @@ public class ChromiumSourceDirector extends AbstractSourceLookupDirector {
addParticipants(new ISourceLookupParticipant[] { participant } );
}
+ public VmResourceRef findVmResourceRef(IFile file) throws CoreException {
+ VmResourceId vmResourceId = reverseSourceLookup.findVmResource(file);
+ if (vmResourceId == null) {
+ return null;
+ }
+ return VmResourceRef.forVmResourceId(vmResourceId);
+ }
+
private static class AccurateLookupParticipant extends AbstractSourceLookupParticipant {
public String getSourceName(Object object) throws CoreException {
return getSourceNameImpl(object);
@@ -108,13 +117,17 @@ public class ChromiumSourceDirector extends AbstractSourceLookupDirector {
}
private static final Breakpoint.Target.Visitor<VmResourceId> BREAKPOINT_RESOURCE_VISITOR =
- new Breakpoint.Target.Visitor<VmResourceId>() {
+ new BreakpointTypeExtension.ScriptRegExpSupport.Visitor<VmResourceId>() {
@Override public VmResourceId visitScriptName(String scriptName) {
return new VmResourceId(scriptName, null);
}
@Override public VmResourceId visitScriptId(long scriptId) {
return new VmResourceId(null, scriptId);
}
+ @Override public VmResourceId visitRegExp(String regExp) {
+ // RegExp cannot be converted into VmResourceId without additional context.
+ return null;
+ }
@Override public VmResourceId visitUnknown(Breakpoint.Target target) {
return null;
}
@@ -126,10 +139,6 @@ public class ChromiumSourceDirector extends AbstractSourceLookupDirector {
this.reverseSourceLookup = new ReverseSourceLookup(this);
}
- public VmResourceId findVmResource(IFile file) throws CoreException {
- return reverseSourceLookup.findVmResource(file);
- }
-
public ReverseSourceLookup getReverseSourceLookup() {
return reverseSourceLookup;
}
« no previous file with comments | « no previous file | plugins/org.chromium.debug.core/src/org/chromium/debug/core/model/BreakpointSynchronizer.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698