Issue 7234010: HBasicBlock::CreateSimulate argument name clarity

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7234010: HBasicBlock::CreateSimulate argument name clarity (Closed)

Created:
9 years, 6 months ago by wingo

Modified:
9 years, 6 months ago

Reviewers:
Kasper Lund, Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/trunk

Visibility:
Public.

Description

HBasicBlock::CreateSimulate argument name clarity * src/hydrogen.h: * src/hydrogen.cc (HBasicBlock::CreateSimulate): Rename "id" arg to "ast_id". BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=8385

Patch Set 1 #

Patch Set 2 : The same rename, but in more places. #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -11 lines)			Patch
	M	src/hydrogen.h	View	1	3 chunks	+4 lines, -4 lines	0 comments	Download
	M	src/hydrogen.cc	View	1	5 chunks	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

wingo

Added Kasper as a reviewer. Please let me know if there is a more appropriate ...

9 years, 6 months ago (2011-06-22 15:30:21 UTC) #2

Mads Ager (chromium)

9 years, 6 months ago (2011-06-23 06:25:04 UTC) #4

On selecting a reviewer: I would probably use 'svn annotate' to find out who
last changed the surrounding code and pick a reviewer based on that. We will
reassign if someone else is better suited.

Thanks for the patch.

Expand Messages | Collapse Messages