Issue 7234009: sandbox: avoid an extra if() which is not required and is wrong

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7234009: sandbox: avoid an extra if() which is not required and is wrong (Closed)

Created:
9 years, 6 months ago by Timur Iskhodzhanov

Modified:
9 years, 5 months ago

Reviewers:
cpu_(ooo_6.6-7.5), rvargas (doing something else), commit-bot: I haz the power

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Avoid an extra if() which is not required and is wrong Info: a) args[i] is uninitialized for (i >= ipc_params->GetParamsCount()) and sometimes for smaller (i) as well (see GetArgs()). Hence, if() is wrong. b) However, when args[i] is uninitialized the ipc_params->args[i] holds INVALID_TYPE. Hence, the if() is redundant. BUG=87078 TEST=no more uninit reports under Dr. Memory Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90742