Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 7234004: Limit the size of the space reserved for code on systems that (Closed)

Created:
9 years, 6 months ago by Erik Corry
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Limit the size of the space reserved for code on systems that are short of virtual memory. This should make V8 work in 64 bit on OpenBSD in its default configuration. It is a simplified version of the reverted 8133 which also lowered the non-code heap size, causing test failures in Chromium on MacOS. Committed: http://code.google.com/p/v8/source/detail?r=8363

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
M src/heap.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download
M src/platform.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/platform-posix.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M src/platform-win32.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Erik Corry
9 years, 6 months ago (2011-06-22 09:01:59 UTC) #1
Mads Ager (chromium)
It seems you are missing updates to a number of platform files? http://codereview.chromium.org/7234004/diff/1/src/heap.cc File src/heap.cc ...
9 years, 6 months ago (2011-06-22 09:42:01 UTC) #2
Erik Corry
All non-Windows platforms use platform-posix.cc. http://codereview.chromium.org/7234004/diff/1/src/heap.cc File src/heap.cc (right): http://codereview.chromium.org/7234004/diff/1/src/heap.cc#newcode159 src/heap.cc:159: intptr_t eighth = max_virtual ...
9 years, 6 months ago (2011-06-22 09:56:36 UTC) #3
Mads Ager (chromium)
9 years, 6 months ago (2011-06-22 10:07:49 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698