Add a flag to open files in share delete mode

Add a flag to open files in share delete mode

BUG=86928
TEST=base_unittests


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90071

[jochen (gone - plz use gerrit), 2011-06-22 13:15:17]

please review

(cpu for code, brettw as owner, mirandac fyi)

[brettw, 2011-06-22 16:04:51]

It's not clear how this will be used. The thing the bug describes is
cross-platform, what's the plan for other platforms?

[jochen (gone - plz use gerrit), 2011-06-22 16:15:47]

On Wed, Jun 22, 2011 at 6:04 PM, <brettw@chromium.org> wrote:

> It's not clear how this will be used. The thing the bug describes is
> cross-platform, what's the plan for other platforms?


On other platforms, you can delete an open file (note that the unit tests
runs on all platforms)


>
>
>
http://codereview.chromium.**org/7233007/<http://codereview.chromium.org/7233...
>

[jochen (gone - plz use gerrit), 2011-06-22 16:28:09]

here's the CL that's gonna use this: http://codereview.chromium.org/7234014

[brettw, 2011-06-22 16:34:34]

On 2011/06/22 16:15:47, jochen wrote:
> On Wed, Jun 22, 2011 at 6:04 PM, <mailto:brettw@chromium.org> wrote:
> 
> > It's not clear how this will be used. The thing the bug describes is
> > cross-platform, what's the plan for other platforms?
> 
> 
> On other platforms, you can delete an open file (note that the unit tests
> runs on all platforms)

I see. This references databases. Are the files sqlite databases? Are we sure
that sqlite isn't guaranteed to close the file and reopen it? It seems like for
commits or things like vacuum it could very well close the file and recreate it.

[jochen (gone - plz use gerrit), 2011-06-22 16:46:19]

On Jun 22, 2011 6:34 PM, <brettw@chromium.org> wrote:
>
> On 2011/06/22 16:15:47, jochen wrote:
>
>> On Wed, Jun 22, 2011 at 6:04 PM, <mailto:brettw@chromium.org> wrote:
>
>
>> > It's not clear how this will be used. The thing the bug describes is
>> > cross-platform, what's the plan for other platforms?
>
>
>
>> On other platforms, you can delete an open file (note that the unit tests
>> runs on all platforms)
>
>
> I see. This references databases. Are the files sqlite databases? Are we
sure
> that sqlite isn't guaranteed to close the file and reopen it? It seems
like for
> commits or things like vacuum it could very well close the file and
recreate it.

The delete on close flag is set in the destructor of the database tracker.
Even if sqlite opens and closes the file during runtime nothing happens

>
>
> http://codereview.chromium.org/7233007/

[brettw, 2011-06-22 17:05:32]

LGTM

[cpu_(ooo_6.6-7.5), 2011-06-22 17:39:05]

lgtm

[commit-bot: I haz the power, 2011-06-22 19:29:24]

Change committed as 90071