Store/Retrieve CrOS user policy in session_manager.

chrome/browser/chromeos/cros/login_library.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_CROS_LOGIN_LIBRARY_H_
 #define CHROME_BROWSER_CHROMEOS_CROS_LOGIN_LIBRARY_H_
 #pragma once
 
 #include <string>
 
 #include "base/memory/singleton.h"
 #include "third_party/cros/chromeos_login.h"
 
 namespace chromeos {
 
 // This interface defines the interaction with the ChromeOS login library APIs.
 class LoginLibrary {
  public:
   virtual ~LoginLibrary();
   // Requests that the Upstart signal login-prompt-ready be emitted.
   virtual bool EmitLoginPromptReady() = 0;
 
+  // Starts a policy retrieval operation. The result will be reported through
+  // |callback|, passing |delegate| verbatimely as the first parameter.
   virtual void RequestRetrievePolicy(RetrievePolicyCallback callback,

[gfeher, 2011/07/21 12:24:23]

Is this about device policies? Then please rename to
RequestRetrieveDevicePolicy.

[Mattias Nissler (ping if slow), 2011/07/21 14:20:25]

You are right in that changing the names would be nicer from the Chrome
perspective. However, then the naming would be out of sync with what libcros and
DBus uses. Changing there is more complicated, due to the multiple repositories
involved. So at this point you can pick: Change here and have an inconsistency
or not change and live with the slightly inaccurate naming. Which do you choose?
:)

[gfeher, 2011/07/21 23:37:14]

My choice: leave it like this for now and do the full rename on the day when all
our bigger problems become resolved.

Okay, wait: please add the word "device" to the comments.

[Mattias Nissler (ping if slow), 2011/07/22 11:29:47]

Done.

-                                     void* delegate_string) = 0;
+                                     void* delegate) = 0;
 
+  // Starts storing |policy| (which should be the serialized form of a
+  // PolicyFetchResponse protobuf). The result will be reported through
+  // |callback|, passing |delegate| verbatimely as the first parameter.
   virtual void RequestStorePolicy(const std::string& policy,

[gfeher, 2011/07/21 12:24:23]

Same here.

[Mattias Nissler (ping if slow), 2011/07/21 14:20:25]

Same reply.

                                   StorePolicyCallback callback,
-                                  void* delegate_bool) = 0;
+                                  void* delegate) = 0;
+
+  // Starts a user policy retrieval operation for the current user. The result
+  // will be reported through |callback|, passing |delegate| verbatimely as the
+  // first parameter.
+  virtual void RequestRetrieveUserPolicy(RetrievePolicyCallback callback,
+                                         void* delegate) = 0;
+
+  // Stores user policy for the current user. The policy data is in |policy|,
+  // which should be a serialized PolicyFetchResponse protobuf. The result will
+  // be reported through |callback|, passing |delegate| verbatimely as the first
+  // parameter.
+  virtual void RequestStoreUserPolicy(const std::string& policy,
+                                      StorePolicyCallback callback,
+                                      void* delegate) = 0;
 
   // Tells the session manager to start a logged-in session for the user
   // |user_email|.  |unique_id| is meant to be used when we have a non-human-
   // readable unique identifier by which we distinguish users (to deal with
   // potential email address changes over time).
   virtual bool StartSession(const std::string& user_email,
                             const std::string& unique_id /* unused */) = 0;
 
   // Tells the session manager to terminate the current logged-in session.
   // In the event that we ever support multiple simultaneous user sessions,
   // This will tell the session manager to terminate the session for the user
   // indicated by |unique_id|.
   virtual bool StopSession(const std::string& unique_id /* unused */) = 0;
 
   // Restarts the Enterprise Daemon.
   virtual bool RestartEntd() = 0;
 
   // Restarts the job with specified command line string.
   virtual bool RestartJob(int pid, const std::string& command_line) = 0;
 
   // Factory function, creates a new instance and returns ownership.
   // For normal usage, access the singleton via CrosLibrary::Get().
   static LoginLibrary* GetImpl(bool stub);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROME_BROWSER_CHROMEOS_CROS_LOGIN_LIBRARY_H_