chrome/browser/ui/views/tabs/base_tab.cc - Issue 7232028: Fixes crash when closing tab then quickly right clicking. The problem

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/tabs/base_tab.cc

Issue 7232028: Fixes crash when closing tab then quickly right clicking. The problem (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/tabs/base_tab.cc

diff --git a/chrome/browser/ui/views/tabs/base_tab.cc b/chrome/browser/ui/views/tabs/base_tab.cc

index af5e41e652b6866de1ffac36412937a200a4a252..44c136484c669d4e533e0e9836423b0f50ab0986 100644

--- a/chrome/browser/ui/views/tabs/base_tab.cc

+++ b/chrome/browser/ui/views/tabs/base_tab.cc

@@ -513,7 +513,7 @@ void BaseTab::ButtonPressed(views::Button* sender, const views::Event& event) {

void BaseTab::ShowContextMenuForView(views::View* source,

const gfx::Point& p,

bool is_mouse_gesture) {

- if (controller())

+ if (controller() && !closing())

controller()->ShowContextMenuForTab(this, p);

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »