Fixes crash when closing tab then quickly right clicking. The problem

Fixes crash when closing tab then quickly right clicking. The problem
is we attempt to show a content menu for a TabContents that is no
longer in the model.

BUG=86713
TEST=see bug
R=ben@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91357

[Ben Goodger (Google), 2011-07-01 17:47:26]

LGTM

On Fri, Jul 1, 2011 at 10:42 AM, <sky@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Description:
> Fixes crash when closing tab then quickly right clicking. The problem
> is we attempt to show a content menu for a TabContents that is no
> longer in the model.
>
> BUG=86713
> TEST=see bug
> R=ben@chromium.org
>
>
> Please review this at
http://codereview.chromium.**org/7232028/<http://codereview.chromium.org/7232...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M chrome/browser/ui/views/tabs/**base_tab.cc
>
>
> Index: chrome/browser/ui/views/tabs/**base_tab.cc
> diff --git a/chrome/browser/ui/views/**tabs/base_tab.cc
> b/chrome/browser/ui/views/**tabs/base_tab.cc
> index af5e41e652b6866de1ffac36412937**a200a4a252..**
> 44c136484c669d4e533e0e9836423b**0f50ab0986 100644
> --- a/chrome/browser/ui/views/**tabs/base_tab.cc
> +++ b/chrome/browser/ui/views/**tabs/base_tab.cc
> @@ -513,7 +513,7 @@ void BaseTab::ButtonPressed(views::**Button* sender,
> const views::Event& event) {
>  void BaseTab::**ShowContextMenuForView(views::**View* source,
>                                      const gfx::Point& p,
>                                      bool is_mouse_gesture) {
> -  if (controller())
> +  if (controller() && !closing())
>     controller()->**ShowContextMenuForTab(this, p);
>  }
>
>
>
>