Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 7232025: Clean up of -Wunused-but-set-variable (gcc 4.6) (Closed)

Created:
9 years, 6 months ago by ph34r
Modified:
9 years, 6 months ago
CC:
chromium-reviews, brettw-cc_chromium.org, Paweł Hajdan Jr., Ryan Sleevi
Visibility:
Public.

Description

Clean up of -Wunused-but-set-variable (gcc 4.6) BUG=80071 TEST=base_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90489

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M base/id_map_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M base/system_monitor/system_monitor_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
ph34r
It's my first contribution, so I make it small just to see how things work. ...
9 years, 6 months ago (2011-06-22 19:56:20 UTC) #1
willchan no longer on Chromium
LGTM Have you signed the CLA yet? There's an electronic submission at the bottom of ...
9 years, 6 months ago (2011-06-22 20:05:02 UTC) #2
ph34r
On 2011/06/22 20:05:02, willchan wrote: > LGTM > > Have you signed the CLA yet? ...
9 years, 6 months ago (2011-06-22 20:08:23 UTC) #3
willchan no longer on Chromium
Great, I'll send this to the commit-bot then. Thanks for the patch. On 2011/06/22 20:08:23, ...
9 years, 6 months ago (2011-06-23 06:58:48 UTC) #4
M-A Ruel
I'll take a look about why this change wasn't committed already.
9 years, 6 months ago (2011-06-23 14:15:57 UTC) #5
commit-bot: I haz the power
Failed to send try job 7232025-1: 2
9 years, 6 months ago (2011-06-24 16:46:44 UTC) #6
M-A Ruel
Sorry for the hickup, it's still processing the patch. http://build.chromium.org/p/tryserver.chromium/waterfall?reload=120&committer=commit-bot@chromium.org
9 years, 6 months ago (2011-06-24 17:03:42 UTC) #7
M-A Ruel
On 2011/06/24 17:03:42, Marc-Antoine Ruel wrote: > Sorry for the hickup, it's still processing the ...
9 years, 6 months ago (2011-06-25 01:46:55 UTC) #8
M-A Ruel
Finally.. http://build.chromium.org/p/tryserver.chromium/waterfall?committer=commit-bot@chromium.org Sorry for the delay. The patch should get in in less than 2 ...
9 years, 6 months ago (2011-06-25 02:07:50 UTC) #9
commit-bot: I haz the power
9 years, 6 months ago (2011-06-25 04:33:20 UTC) #10
Change committed as 90489

Powered by Google App Engine
This is Rietveld 408576698