Added last_modified field to TemplateURL and database. Updated unit tests, including refactoring ...

chrome/browser/search_engines/template_url_service.cc

Index: chrome/browser/search_engines/template_url_service.cc
===================================================================
--- chrome/browser/search_engines/template_url_service.cc	(revision 90021)
+++ chrome/browser/search_engines/template_url_service.cc	(working copy)
@@ -102,7 +102,8 @@
       load_handle_(0),
       default_search_provider_(NULL),
       is_default_search_managed_(false),
-      next_id_(1) {
+      next_id_(1),
+      time_provider_(&base::Time::Now) {
   DCHECK(profile_);
   Init(NULL, 0);
 }
@@ -116,7 +117,8 @@
       service_(NULL),
       default_search_provider_(NULL),
       is_default_search_managed_(false),
-      next_id_(1) {
+      next_id_(1),
+      time_provider_(&base::Time::Now) {
   Init(initializers, count);
 }
 
@@ -399,6 +401,7 @@
     new_url.SetURL(search_url, 0, 0);
   }
   new_url.set_safe_for_autoreplace(false);
+  new_url.set_last_modified(time_provider_());
   UpdateNoNotify(url, new_url);
   NotifyObservers();
 }
@@ -634,6 +637,15 @@
                             PrefService::UNSYNCABLE_PREF);
 }
 
+void TemplateURLService::InstallTimeProvider(TimeProvider* time_provider) {

[sky, 2011/06/22 22:38:06]

Rename to set_time_provider, inline it and wrap it in #if defined(UNIT_TEST)

[SteveT, 2011/06/23 21:15:55]

Done.

+  DCHECK(time_provider);
+  time_provider_ = time_provider;
+}
+
+void TemplateURLService::UninstallTimeProvider() {
+  time_provider_ = &base::Time::Now;

[sky, 2011/06/22 22:38:06]

Let the tests that care handle this. In fact based on your test I bet you don't
need it at all.

[SteveT, 2011/06/23 21:15:55]

Removed it in favour of managing it with set_time_provider. Since I was just
uninstalling the TimeProvider at the end of tests, I removed calls to it since
it doesn't affect following tests.

+}
+
 void TemplateURLService::SetKeywordSearchTermsForURL(const TemplateURL* t_url,
                                                      const GURL& url,
                                                      const string16& term) {