Issue 7232008: Update the text for the Page Info bubble for internal pages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7232008: Update the text for the Page Info bubble for internal pages. (Closed)

Created:
9 years, 6 months ago by Finnur

Modified:
9 years, 6 months ago

Reviewers:
Jay Civelli

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Update the text for the Page Info bubble for internal pages. BUG=80694 TEST=Navigate to a chrome:// page and open the bubble and see "You are viewing a secure [Google Chrome | Chromium]page" Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90353

Patch Set 1 #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/app/chromium_strings.grd	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/app/google_chrome_strings.grd	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jay Civelli

9 years, 6 months ago (2011-06-22 16:05:06 UTC) #2

LGTM

On Wed, Jun 22, 2011 at 4:01 AM,  <finnur@chromium.org> wrote:
> Reviewers: Jay Civelli,
>
> Description:
> Update the text for the Page Info bubble for internal pages.
>
> BUG=80694
> TEST=Navigate to a chrome:// page and open the bubble and see "You are
> viewing a
> secure [Google Chrome | Chromium]page"
>
> Please review this at http://codereview.chromium.org/7232008/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     chrome/app/chromium_strings.grd
>  M     chrome/app/google_chrome_strings.grd
>
>
> Index: chrome/app/chromium_strings.grd
> ===================================================================
> --- chrome/app/chromium_strings.grd     (revision 89808)
> +++ chrome/app/chromium_strings.grd     (working copy)
> @@ -535,7 +535,7 @@
>       </message>
>       <!-- Page Info bubble -->
>       <message name="IDS_PAGE_INFO_INTERNAL_PAGE" desc="Message to display
> in the page info bubble when the page you are on is a chrome:// page or
> about:something.">
> -        This page was generated by Chromium.
> +        You are viewing a secure Chromium page.
>       </message>
>       <!-- Print Preview -->
>       <message name="IDS_PRINT_PREVIEW_NO_PLUGIN" desc="Message to display
> when the PDF viewer is missing.">
> Index: chrome/app/google_chrome_strings.grd
> ===================================================================
> --- chrome/app/google_chrome_strings.grd        (revision 89808)
> +++ chrome/app/google_chrome_strings.grd        (working copy)
> @@ -527,7 +527,7 @@
>       </message>
>       <!-- Page Info bubble -->
>       <message name="IDS_PAGE_INFO_INTERNAL_PAGE" desc="Message to display
> in the page info bubble when the page you are on is a chrome:// page or
> about:something.">
> -        This page was generated by Google Chrome.
> +        You are viewing a secure Google Chrome page.
>       </message>
>       <!-- Print Preview -->
>       <message name="IDS_PRINT_PREVIEW_NO_PLUGIN" desc="Message to display
> when the PDF viewer is missing.">
>
>
>

Expand Messages | Collapse Messages