Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7232003: Move MachBroker to content. (Closed)

Created:
9 years, 6 months ago by jam
Modified:
9 years, 6 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Move MachBroker to content. BUG=76697 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90236

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -432 lines) Patch
M chrome/app/chrome_main.cc View 1 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/mach_broker_mac.h View 1 chunk +0 lines, -112 lines 0 comments Download
D chrome/browser/mach_broker_mac.cc View 1 chunk +0 lines, -237 lines 0 comments Download
D chrome/browser/mach_broker_mac_unittest.cc View 1 chunk +0 lines, -60 lines 0 comments Download
M chrome/browser/prerender/prerender_contents.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/task_manager/task_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/child_process_launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/mach_broker_mac.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/mach_broker_mac.cc View 4 chunks +2 lines, -10 lines 0 comments Download
A + content/browser/mach_broker_mac_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/content_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jam
I couldn't find a non-ugly way to abstract this out, so I just moved the ...
9 years, 6 months ago (2011-06-22 02:23:39 UTC) #1
jam
9 years, 6 months ago (2011-06-22 21:49:07 UTC) #2
Avi (use Gerrit)
http://codereview.chromium.org/7232003/diff/7001/webkit/plugins/ppapi/ppapi_plugin_instance.cc File webkit/plugins/ppapi/ppapi_plugin_instance.cc (left): http://codereview.chromium.org/7232003/diff/7001/webkit/plugins/ppapi/ppapi_plugin_instance.cc#oldcode1408 webkit/plugins/ppapi/ppapi_plugin_instance.cc:1408: canvas.drawARGB(255, 255, 255, 255); This change doesn't appear to ...
9 years, 6 months ago (2011-06-22 21:54:14 UTC) #3
jam
http://codereview.chromium.org/7232003/diff/7001/webkit/plugins/ppapi/ppapi_plugin_instance.cc File webkit/plugins/ppapi/ppapi_plugin_instance.cc (left): http://codereview.chromium.org/7232003/diff/7001/webkit/plugins/ppapi/ppapi_plugin_instance.cc#oldcode1408 webkit/plugins/ppapi/ppapi_plugin_instance.cc:1408: canvas.drawARGB(255, 255, 255, 255); On 2011/06/22 21:54:14, Avi wrote: ...
9 years, 6 months ago (2011-06-22 21:58:27 UTC) #4
Avi (use Gerrit)
9 years, 6 months ago (2011-06-22 22:11:10 UTC) #5 
LGTM

Powered by Google App Engine
This is Rietveld 408576698