Issue 7232002: net doesn't depend on libevent directly now.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7232002: net doesn't depend on libevent directly now. (Closed)

Created:
9 years, 6 months ago by wtc

Modified:
9 years, 6 months ago

Reviewers:
Mark Mentovai, commit-bot: I haz the power, rvargas (doing something else)

CC:
chromium-reviews, cbentzel+watch_chromium.org, brettw-cc_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

net doesn't depend on libevent directly now. Remove unnecessary forward declarations of struct event and inclusions of the event.h header. Use MessageLoopForIO::FileDescriptorWatcher and MessageLoopForIO::Watcher typedefs. R=mark@chromium.org,rvargas@chromium.org BUG=none TEST=no build errors Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89995

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -33 lines)			Patch
M	base/message_loop_unittest.cc	View	1	4 chunks	+3 lines, -6 lines	0 comments	Download
M	base/message_pump_libevent_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/base/listen_socket.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	net/base/listen_socket.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	net/net.gyp	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	net/socket/tcp_client_socket_libevent.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	net/socket/tcp_client_socket_libevent.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	net/socket/tcp_server_socket_libevent.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	net/udp/udp_socket_libevent.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download

Total messages: 4 (0 generated)

Change committed as 89995