Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7231016: Move app/win/* files to base/win/, ui/base/win and chrome/common/ directories. (Closed)

Created:
9 years, 6 months ago by tfarina
Modified:
9 years, 6 months ago
Reviewers:
Robert Sesek, brettw
CC:
chromium-reviews, Avi (use Gerrit), tfarina, amit, brettw-cc_chromium.org, jam, cbentzel+watch_chromium.org, apatrick_chromium, joi+watch-content_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., pam+watch_chromium.org
Visibility:
Public.

Description

Move app/win/* files to base/win/, ui/base/win and chrome/common/ directories. BUG=72317 TEST=None R=rsesek@chromium.org,brettw@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90464

Patch Set 1 : #

Total comments: 4

Patch Set 2 : brettw review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -723 lines) Patch
M app/app_base.gypi View 1 chunk +0 lines, -6 lines 0 comments Download
D app/win/iat_patch_function.h View 1 chunk +0 lines, -72 lines 0 comments Download
D app/win/iat_patch_function.cc View 1 chunk +0 lines, -278 lines 0 comments Download
D app/win/scoped_co_mem.h View 1 chunk +0 lines, -49 lines 0 comments Download
D app/win/scoped_com_initializer.h View 1 chunk +0 lines, -60 lines 0 comments Download
D app/win/shell.h View 1 chunk +0 lines, -41 lines 0 comments Download
D app/win/shell.cc View 1 chunk +0 lines, -112 lines 0 comments Download
M base/base.gypi View 1 3 chunks +7 lines, -4 lines 0 comments Download
A + base/win/iat_patch_function.h View 2 chunks +6 lines, -6 lines 0 comments Download
A + base/win/iat_patch_function.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + base/win/scoped_com_initializer.h View 4 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/aeropeek_manager.cc View 1 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/browser_main.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/importer/ie_importer.cc View 1 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/importer/importer_unittest.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/platform_util_win.cc View 1 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/tab_contents/web_drop_target_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_win.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/chrome_common.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_paths_win.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
A + chrome/common/scoped_co_mem.h View 1 2 chunks +9 lines, -9 lines 0 comments Download
M chrome/common/win_safe_util.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/renderer/chrome_render_process_observer.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/utility/chrome_content_utility_client.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome_frame/test/net/fake_external_tab.cc View 4 chunks +3 lines, -3 lines 0 comments Download
M chrome_frame/test/url_request_test.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M content/browser/geolocation/win7_location_api_win.h View 2 chunks +4 lines, -4 lines 0 comments Download
content/common/gpu/gpu_channel_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/gpu/gpu_child_thread.cc View 2 chunks +2 lines, -2 lines 0 comments Download
content/gpu/gpu_main.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + ui/base/win/shell.h View 1 3 chunks +7 lines, -6 lines 0 comments Download
A + ui/base/win/shell.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M ui/ui_base.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/plugins/npapi/webplugin_delegate_impl_win.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M webkit/tools/test_shell/mac/webwidget_host.mm View 5 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tfarina
9 years, 6 months ago (2011-06-22 18:51:03 UTC) #1
brettw
I don't understand the motivation for this change. The referenced bug says "src/ui/base should have ...
9 years, 6 months ago (2011-06-23 15:48:05 UTC) #2
Robert Sesek
On 2011/06/23 15:48:05, brettw wrote: > I don't understand the motivation for this change. The ...
9 years, 6 months ago (2011-06-23 15:50:23 UTC) #3
brettw
http://codereview.chromium.org/7231016/diff/2001/base/win/scoped_co_mem.h File base/win/scoped_co_mem.h (right): http://codereview.chromium.org/7231016/diff/2001/base/win/scoped_co_mem.h#newcode5 base/win/scoped_co_mem.h:5: #ifndef BASE_WIN_SCOPED_CO_MEM_H_ It looks like this isn't used outside ...
9 years, 6 months ago (2011-06-23 16:13:04 UTC) #4
tfarina
http://codereview.chromium.org/7231016/diff/2001/base/win/scoped_co_mem.h File base/win/scoped_co_mem.h (right): http://codereview.chromium.org/7231016/diff/2001/base/win/scoped_co_mem.h#newcode5 base/win/scoped_co_mem.h:5: #ifndef BASE_WIN_SCOPED_CO_MEM_H_ On 2011/06/23 16:13:04, brettw wrote: > It ...
9 years, 6 months ago (2011-06-23 16:50:12 UTC) #5
tfarina
ping?
9 years, 6 months ago (2011-06-24 16:55:44 UTC) #6
brettw
9 years, 6 months ago (2011-06-24 19:57:34 UTC) #7 
LGTM

Powered by Google App Engine
This is Rietveld 408576698