src/ia32/lithium-ia32.cc - Issue 7231008: Fix an overflow in on-stack replacement spill-slot allocation for Crankshaft.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/lithium-ia32.cc

Issue 7231008: Fix an overflow in on-stack replacement spill-slot allocation for Crankshaft. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/lithium-ia32.cc

diff --git a/src/ia32/lithium-ia32.cc b/src/ia32/lithium-ia32.cc

index 6f2f8d62b844e37a0a79fed94524de5fdb01efd4..19415975e2d6db65eb9f481633994234b9246e22 100644

--- a/src/ia32/lithium-ia32.cc

+++ b/src/ia32/lithium-ia32.cc

@@ -2168,6 +2168,9 @@ LInstruction* LChunkBuilder::DoParameter(HParameter* instr) {

LInstruction* LChunkBuilder::DoUnknownOSRValue(HUnknownOSRValue* instr) {

int spill_index = chunk()->GetNextSpillIndex(false); // Not double-width.

+ if (spill_index > LUnallocated::kMaxFixedIndex) {

+ Abort("Too many spill slots needed for OSR");

+ }

return DefineAsSpilled(new LUnknownOSRValue, spill_index);

}

« no previous file with comments | « src/compiler.cc ('k') | src/lithium.h » ('j') | no next file with comments »