Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Side by Side Diff: src/x64/lithium-x64.cc

Issue 7231008: Fix an overflow in on-stack replacement spill-slot allocation for Crankshaft. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/lithium.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2094 matching lines...) Expand 10 before | Expand all | Expand 10 after
2105 2105
2106 2106
2107 LInstruction* LChunkBuilder::DoParameter(HParameter* instr) { 2107 LInstruction* LChunkBuilder::DoParameter(HParameter* instr) {
2108 int spill_index = chunk()->GetParameterStackSlot(instr->index()); 2108 int spill_index = chunk()->GetParameterStackSlot(instr->index());
2109 return DefineAsSpilled(new LParameter, spill_index); 2109 return DefineAsSpilled(new LParameter, spill_index);
2110 } 2110 }
2111 2111
2112 2112
2113 LInstruction* LChunkBuilder::DoUnknownOSRValue(HUnknownOSRValue* instr) { 2113 LInstruction* LChunkBuilder::DoUnknownOSRValue(HUnknownOSRValue* instr) {
2114 int spill_index = chunk()->GetNextSpillIndex(false); // Not double-width. 2114 int spill_index = chunk()->GetNextSpillIndex(false); // Not double-width.
2115 if (spill_index > LUnallocated::kMaxFixedIndex) {
2116 Abort("Too many spill slots needed for OSR");
2117 }
2115 return DefineAsSpilled(new LUnknownOSRValue, spill_index); 2118 return DefineAsSpilled(new LUnknownOSRValue, spill_index);
2116 } 2119 }
2117 2120
2118 2121
2119 LInstruction* LChunkBuilder::DoCallStub(HCallStub* instr) { 2122 LInstruction* LChunkBuilder::DoCallStub(HCallStub* instr) {
2120 argument_count_ -= instr->argument_count(); 2123 argument_count_ -= instr->argument_count();
2121 return MarkAsCall(DefineFixed(new LCallStub, rax), instr); 2124 return MarkAsCall(DefineFixed(new LCallStub, rax), instr);
2122 } 2125 }
2123 2126
2124 2127
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
2224 LOperand* key = UseOrConstantAtStart(instr->key()); 2227 LOperand* key = UseOrConstantAtStart(instr->key());
2225 LOperand* object = UseOrConstantAtStart(instr->object()); 2228 LOperand* object = UseOrConstantAtStart(instr->object());
2226 LIn* result = new LIn(key, object); 2229 LIn* result = new LIn(key, object);
2227 return MarkAsCall(DefineFixed(result, rax), instr); 2230 return MarkAsCall(DefineFixed(result, rax), instr);
2228 } 2231 }
2229 2232
2230 2233
2231 } } // namespace v8::internal 2234 } } // namespace v8::internal
2232 2235
2233 #endif // V8_TARGET_ARCH_X64 2236 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/lithium.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698